-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refine LAC computation of avg_speed #8277
Conversation
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
Signed-off-by: guo-shaoge <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SeaRise, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
@guo-shaoge: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-integration-test |
/hold |
Signed-off-by: guo-shaoge <[email protected]>
/run-all-tests |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #8287
Problem Summary:
ru_consumption_speed
is the avg speed of last 5 seconds.ru_consumption_delta
is the ru consumption of last 5 seconds, it will be set to zero after report consumption to GAC every 5 seconds.Others:
needNotifyStopTrickleMode
to exit trickle mode timely. Otherwise it's possiable LAC cannot talk to GAC because always got enough token(a.k.a. the fill rate of trickle mode is large enough)ACQUIRE_RU_AMPLIFICATION
from 1.1 to 1.5. Although tidb also use 1.1, but IMO it's a little small.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note