-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Upgrade fmtlib and print enum value explicitly #8332
Conversation
/run-all-tests |
/run-all-tests |
Co-authored-by: Lloyd-Pottiger <[email protected]>
Co-authored-by: Lloyd-Pottiger <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/run-all-tests |
/run-all-tests |
/run-all-tests |
String expected | ||
= "window_2 | partition_by: {(<1, String>, desc: false)}}, order_by: {(<0, String>, desc: " | ||
"true)}, func_desc: {row_number()}, frame: {start<CurrentRow, false, 0>, end<CurrentRow, false, 0>}\n" | ||
" sort_1 | isPartialSort: true, partition_by: {(<0, String>, desc: false)}\n" | ||
" table_scan_0 | {<0, String>, <1, String>}\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cause by the changes in TestUtils/ExecutorSerializer.cpp
/run-all-tests |
What problem does this PR solve?
Issue Number: close #8331
Problem Summary:
The latest version of fmtlib disables implicit casts from
enum
/enum class
toint
, which leads to compile error. We must resolve those errors withmagic_enum::enum_name
to print out the enum nam orfmt::underlying
to print out the int value.Reference: fmtlib/fmt#3671
An example of the compile error raised by upgraded fmtlib
What is changed and how it works?
magic_enum::enum_name
to cast it to stringfmt::underlying
to cast it to intformat_as
function to make it printable by fmtlibMppVersion
/MPPDataPacketVersion
/StringRef
/SettingInt
/SettingFloat
/SettingDouble
Check List
Tests
Side effects
Documentation
Release note