Fix hash join crash

[windtalker]

What problem does this PR solve?

Issue Number: close #8633

Problem Summary:

What is changed and how it works?

The root cause is in Join::finalize, it may add some REMOVE_COLUMN action in other_cond_expr if it is not semi or nullaware join:

tiflash/dbms/src/Interpreters/Join.cpp

Line 2654 in ce42814

non_equal_conditions.other_cond_expr->finalize(updated_require, keep_used_input_columns);

however, for function handleOtherCondition(),

tiflash/dbms/src/Interpreters/Join.cpp

Lines 850 to 854 in ce42814

	void Join::handleOtherConditions(
	Block & block,
	IColumn::Filter * anti_filter,
	IColumn::Offsets * offsets_to_replicate,
	const std::vector<size_t> & right_table_columns) const

right_table_columns is a index based on previous block, of there is REMOVE_COLUMN action in other_cond_expr, the index will become invalid.

This pr disable generating REMOVE_COLUMN during Join::finalize. It is possible that refine the code in handleOtherCondition so it does not depends on the index based right_table_columns, but I would like to do it in a standalone pr later since there is no too much time before a new release.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[SeaRise]

lgtm

[yibin87]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [SeaRise,yibin87]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-01-02 07:57:49.378008217 +0000 UTC m=+2157360.415235142: ☑️ agreed by SeaRise.
• 2024-01-02 08:47:17.411255277 +0000 UTC m=+2160328.448482204: ☑️ agreed by yibin87.

[ti-chi-bot]

@windtalker: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[windtalker]

/rebuild

[windtalker]

/run-all-tests

[JaySon-Huang]

/run-all-tests