Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine handleOtherConditions in join #8642

Merged
merged 4 commits into from
Jan 10, 2024
Merged

refine handleOtherConditions in join #8642

merged 4 commits into from
Jan 10, 2024

Conversation

windtalker
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #8633

Problem Summary:

What is changed and how it works?

Refine Join::handleOtherConditions so it does not rely on index based right_table_columns

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 3, 2024
@windtalker windtalker changed the title WIP: refine handle_other_conditions in join WIP: refine handleOtherConditions in join Jan 3, 2024
@windtalker
Copy link
Contributor Author

/run-all-tests

@windtalker
Copy link
Contributor Author

/run-integration-tests

@windtalker
Copy link
Contributor Author

/run-all-tests

@windtalker
Copy link
Contributor Author

/run-integration-tests

@windtalker windtalker changed the title WIP: refine handleOtherConditions in join refine handleOtherConditions in join Jan 8, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2024
@windtalker windtalker force-pushed the refine_handle_other_conditions_in_join branch from e2c0637 to b261cdd Compare January 8, 2024 02:10
@windtalker
Copy link
Contributor Author

/run-all-tests

@SeaRise SeaRise self-requested a review January 8, 2024 02:37
SeaRise
SeaRise approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dbms/src/Interpreters/Join.cpp Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 8, 2024
windtalker and others added 2 commits January 8, 2024 10:57
@windtalker
Copy link
Contributor Author

/run-all-tests

@windtalker
Copy link
Contributor Author

/run-integration-tests

yibin87
yibin87 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 10, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-08 02:46:04.153128324 +0000 UTC m=+238553.737382009: ☑️ agreed by SeaRise.
  • 2024-01-10 02:27:54.471832581 +0000 UTC m=+410264.056086269: ☑️ agreed by yibin87.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 10, 2024

@windtalker: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit bd99043 into pingcap:master Jan 10, 2024
6 checks passed
@windtalker windtalker deleted the refine_handle_other_conditions_in_join branch January 10, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaRise SeaRise SeaRise approved these changes

@yibin87 yibin87 yibin87 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@windtalker @yibin87 @SeaRise