Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the issue that building tiflash in mac fail introduced by #8872 #8888

Merged
merged 4 commits into from
Apr 2, 2024
Merged

fix the issue that building tiflash in mac fail introduced by #8872 #8888

merged 4 commits into from
Apr 2, 2024

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Apr 1, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #6233

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Apr 1, 2024
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 1, 2024

/cc @yibin87 @Lloyd-Pottiger

@ti-chi-bot ti-chi-bot bot requested review from Lloyd-Pottiger and yibin87 April 1, 2024 09:06
yibin87
yibin87 approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 1, 2024
@JaySon-Huang JaySon-Huang changed the title fix the issue that building tiflash in mac fail introduced by https://github.com/pingcap/tiflash/pull/8872 fix the issue that building tiflash in mac fail introduced by #8872 Apr 1, 2024
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 1, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 1, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 1, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Lloyd-Pottiger, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Lloyd-Pottiger,yibin87]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-01 09:15:37.784107326 +0000 UTC m=+262599.311647871: ☑️ agreed by yibin87.
  • 2024-04-01 09:55:59.542905055 +0000 UTC m=+265021.070445627: ☑️ agreed by Lloyd-Pottiger.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Apr 2, 2024

/test-unit-test
/test-integration-test

@purelind
Copy link
Collaborator

purelind commented Apr 2, 2024

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 2, 2024

/hold cancel

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2024
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 2, 2024

/run-integration-test

1 similar comment
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 2, 2024

/run-integration-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 2, 2024

/build

@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 2, 2024

/run-integration-test

1 similar comment
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 2, 2024

/run-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 93d7395 into pingcap:master Apr 2, 2024
6 checks passed
@SeaRise SeaRise deleted the fix_mac_build_fail branch April 2, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@yibin87 yibin87 yibin87 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SeaRise @wuhuizuo @purelind @yibin87 @Lloyd-Pottiger