ddl: Fix rename partitioned table is not atomic

[JaySon-Huang]

What problem does this PR solve?

Issue Number: close #9132

Problem Summary:

In the previous implementation, when running RENAME for a partitioned table, it will skip renaming the following partitions if one of the IStorage instance does not exist.

tiflash/dbms/src/TiDB/Schema/SchemaBuilder.cpp

Lines 667 to 691 in 73929ad

	template <typename Getter, typename NameMapper>
	void SchemaBuilder<Getter, NameMapper>::applyRenameLogicalTable(
	const DatabaseID new_database_id,
	const String & new_database_display_name,
	const TableInfoPtr & new_table_info,
	const ManageableStoragePtr & storage)
	{
	applyRenamePhysicalTable(new_database_id, new_database_display_name, *new_table_info, storage);
	if (new_table_info->isLogicalPartitionTable())
	{
	auto & tmt_context = context.getTMTContext();
	for (const auto & part_def : new_table_info->partition.definitions)
	{
	auto part_storage = tmt_context.getStorages().get(keyspace_id, part_def.id);
	if (part_storage == nullptr)
	{
	LOG_ERROR(
	log,
	"Storage instance is not exist in TiFlash, applyRenamePhysicalTable is ignored, "
	"physical_table_id={} logical_table_id={}",
	part_def.id,
	new_table_info->id);
	return;
	}

That work well on the versions before v7.2. But after DDL framework refactor since v7.2, there could be a chance that the IStorage instance is not created.
If there are "p1, p2, p3" for a partitioned table, but "p2" is empty. Then the IStorage instance of "p2" is not created. When we need to rename the partitioned table to another database, it will make that "p1" is renamed to the new database, but "p3" remain in the old database. This cause inconsistency.

What is changed and how it works?

1. applyRenameLogicalTable will continue the rename for remaining partitions even if it happen to a partition that does not have IStorage instance
2. There could be a chance that tiflash restart when applying applyRenameLogicalTable, making some partitions is in the old database while some is in the new database. After restart, syncAllSchema will call tryFixPartitionsBelongingDatabase and check whether there are any partitions that does not belong to the database on disk. If so, rename the partition table to the correct database.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Fix the issue that tiflash may panic after renaming a partitioned table with empty partition to a new database

[ti-chi-bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[CalvinNeo]

Use scoped_lock

[JaySon-Huang]

fixed

[CalvinNeo]

In what case could this happen?

[JaySon-Huang]

Cases under "tests/delta-merge-test" may create table with the given table_name rather that "t_${table_id}"

[CalvinNeo]

Also protect the cast?

[JaySon-Huang]

Added

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-07-11 07:51:13.864050023 +0000 UTC m=+516771.099284136: ☑️ agreed by Lloyd-Pottiger.
• 2024-07-12 02:45:59.697288966 +0000 UTC m=+584856.932523075: ☑️ agreed by JinheLin.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #9219.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.1: #9220.