KVStore: Fallback elegantly when getting table error in FAP #9253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CalvinNeo <[email protected]>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
JaySon-Huang
changed the title
Signed-off-by: CalvinNeo <[email protected]>
ti-chi-bot
bot
added
size/M
CalvinNeo
changed the title
CalvinNeo
changed the title
CalvinNeo
changed the title
Signed-off-by: Calvin Neo <[email protected]>
dbms/src/Storages/KVStore/tests/gtest_kvstore_fast_add_peer.cpp
Outdated
Show resolved
Hide resolved
dbms/src/Storages/KVStore/tests/gtest_kvstore_fast_add_peer.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: JaySon <[email protected]>
Signed-off-by: Calvin Neo <[email protected]>
ti-chi-bot
bot
added
size/L
dbms/src/Storages/KVStore/tests/gtest_kvstore_fast_add_peer.cpp
Outdated
Show resolved
Hide resolved
ti-chi-bot
bot
added
needs-1-more-lgtm
Lloyd-Pottiger
approved these changes
Jul 26, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Aug 2, 2024
…9253) ref pingcap#8673 Co-authored-by: JaySon-Huang <[email protected]> Co-authored-by: JaySon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #8673
Problem Summary:
nullptr is not check after AtomicGetStorageSchema. When user drop a database or a keyspace is removed and FAP happen, tiflash crashes
What is changed and how it works?
Fallback elegantly when fails in getting table.
Check List
Tests
Side effects
Documentation
Release note