Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: Fix unstable test "fullstack-test/mpp/rollup_tpcds.test" (#9628) #9639

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9628

What problem does this PR solve?

Issue Number: close #9613

Problem Summary:
Checkout the details logging in #9613 (comment)
According to the log, it took about 4 seconds to create an empty table when the CI environment is busy.

What is changed and how it works?


  • Increate the max wait time for concurrent create table to 5 seconds.
  • Refine the logging when concurrent create table happen

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Nov 18, 2024
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 18, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 26, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 27, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 27, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-26 09:10:41.932068926 +0000 UTC m=+541229.551723442: ☑️ agreed by Lloyd-Pottiger.
  • 2024-11-27 02:42:24.183268955 +0000 UTC m=+604331.802923469: ☑️ agreed by JaySon-Huang.

@JaySon-Huang
Copy link
Contributor

/retest

2 similar comments
@purelind
Copy link
Collaborator

/retest

@JaySon-Huang
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 6269371 into pingcap:release-8.1 Nov 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants