Storages: refactor DMFileReader #9690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lloyd-Pottiger <[email protected]>
ti-chi-bot
bot
added
the
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
size/XL
Signed-off-by: Lloyd-Pottiger <[email protected]>
Signed-off-by: Lloyd-Pottiger <[email protected]>
12 tasks
JaySon-Huang
reviewed
Dec 9, 2024
| @@ -78,7 +78,6 @@ class ScanContext | |||
| std::atomic<uint64_t> mvcc_input_rows{0}; | |||
| std::atomic<uint64_t> mvcc_input_bytes{0}; | |||
| std::atomic<uint64_t> mvcc_output_rows{0}; | |||
| std::atomic<uint64_t> late_materialization_skip_rows{0}; | |||
There was a problem hiding this comment.
After this is removed, can we directly use dmfile_lm_filter_scanned_rows and dmfile_lm_filter_skipped_rows to check the efficiency of late materialization?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #6233
Problem Summary:
What is changed and how it works?
Pre-compute each read block information to simplify DMFileReader, and we can use the read_block_infos to simplify vector search read path.
pingcap/tidb#58076
Check List
Tests
Side effects
Documentation
Release note