Skip to content

Commit

Permalink
pkg/version(ticdc): bump max version for release 7.1 (#10810)
Browse files Browse the repository at this point in the history
ref #10807
  • Loading branch information
CharlesCheung96 authored Apr 2, 2024
1 parent c43300c commit 217be1f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions pkg/version/check.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,13 @@ var (
minPDVersion = semver.New("5.1.0-alpha")
// maxPDVersion is the version of the maximum compatible PD.
// Compatible versions are in [minPDVersion, maxPDVersion)
maxPDVersion = semver.New("8.0.0")
maxPDVersion = semver.New("9.0.0")

// MinTiKVVersion is the version of the minimal compatible TiKV.
MinTiKVVersion = semver.New("5.1.0-alpha")
// maxTiKVVersion is the version of the maximum compatible TiKV.
// Compatible versions are in [MinTiKVVersion, maxTiKVVersion)
maxTiKVVersion = semver.New("8.0.0")
maxTiKVVersion = semver.New("9.0.0")

// CaptureInfo.Version is added since v4.0.11,
// we use the minimal release version as default.
Expand All @@ -56,7 +56,7 @@ var (
MinTiCDCVersion = semver.New("6.3.0-alpha")
// MaxTiCDCVersion is the version of the maximum allowed TiCDC version.
// for version `x.y.z`, max allowed `x+2.0.0`
MaxTiCDCVersion = semver.New("8.0.0-alpha")
MaxTiCDCVersion = semver.New("9.0.0-alpha")
)

var versionHash = regexp.MustCompile("-[0-9]+-g[0-9a-f]{7,}(-dev)?")
Expand Down
6 changes: 3 additions & 3 deletions pkg/version/check_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -449,21 +449,21 @@ func TestCheckTiCDCVersion(t *testing.T) {

versions = map[string]struct{}{
"v6.3.0": {},
"v8.0.0-alpha": {},
"v9.0.0-alpha": {},
}
err = CheckTiCDCVersion(versions)
require.Regexp(t, "TiCDC .* not supported, only support version less than.*", err)

versions = map[string]struct{}{
"v6.3.0": {},
"v8.0.0-master": {},
"v9.0.0-master": {},
}
err = CheckTiCDCVersion(versions)
require.Regexp(t, "TiCDC .* not supported, only support version less than.*", err)

versions = map[string]struct{}{
"v6.3.0": {},
"v8.0.0": {},
"v9.0.0": {},
}
err = CheckTiCDCVersion(versions)
require.Regexp(t, "TiCDC .* not supported, only support version less than.*", err)
Expand Down

0 comments on commit 217be1f

Please sign in to comment.