Skip to content

Commit

Permalink
makefile(all): fix make check exit code (#7609)
Browse files Browse the repository at this point in the history
close #7608
  • Loading branch information
sleepymole authored Nov 15, 2022
1 parent 436cb8b commit 482239d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ check-static: tools/bin/golangci-lint
check: check-copyright fmt check-static tidy terror_check errdoc \
check-merge-conflicts check-ticdc-dashboard check-diff-line-width \
swagger-spec check-makefiles check_engine_integration_test
@git --no-pager diff --exit-code || echo "Please add changed files!"
@git --no-pager diff --exit-code || (echo "Please add changed files!" && false)

integration_test_coverage: tools/bin/gocovmerge tools/bin/goveralls
tools/bin/gocovmerge "$(TEST_DIR)"/cov.* | grep -vE ".*.pb.go|$(CDC_PKG)/testing_utils/.*|$(CDC_PKG)/cdc/entry/schema_test_helper.go|$(CDC_PKG)/cdc/sink/simple_mysql_tester.go|.*.__failpoint_binding__.go" > "$(TEST_DIR)/all_cov.out"
Expand Down

0 comments on commit 482239d

Please sign in to comment.