mq(ticdc): fix send message time cost duration metrics inaccurate (#7578

) close #7577
pingcap · Nov 10, 2022 · c982fca · c982fca
1 parent b31400b
commit c982fca
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/cdc/sinkv2/eventsink/mq/worker.go b/cdc/sinkv2/eventsink/mq/worker.go
@@ -284,11 +284,11 @@ func (w *worker) sendMessages(ctx context.Context) error {
 					zap.String("changefeed", w.changeFeedID.ID))
 				return nil
 			}
-			start := time.Now()
 			if err := future.Ready(ctx); err != nil {
 				return errors.Trace(err)
 			}
 			for _, message := range future.Messages {
+				start := time.Now()
 				if err := w.statistics.RecordBatchExecution(func() (int, error) {
 					if err := w.producer.AsyncSendMessage(ctx, future.Topic, future.Partition, message); err != nil {
 						return 0, err

diff --git a/cdc/sinkv2/metrics/mq/metrics.go b/cdc/sinkv2/metrics/mq/metrics.go
@@ -25,7 +25,7 @@ var (
 			Namespace: "ticdc",
 			Subsystem: "sinkv2",
 			Name:      "mq_worker_send_message_duration",
-			Help:      "Flush duration(s) for MQ worker.",
+			Help:      "Send Message duration(s) for MQ worker.",
 			Buckets:   prometheus.ExponentialBuckets(0.001, 2, 20), // 1ms~1000s
 		}, []string{"namespace", "changefeed"})
 	// WorkerBatchSize record the size of each batched messages.