Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calculate secondsBehindMaster when dm sync block #3695

Closed
GMHDBJD opened this issue Dec 2, 2021 · 3 comments · Fixed by #4496
Closed

calculate secondsBehindMaster when dm sync block #3695

GMHDBJD opened this issue Dec 2, 2021 · 3 comments · Fixed by #4496
Assignees
@Ehco1996
Labels
area/dm Issues or PRs related to DM. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Dec 2, 2021 •
edited
Loading

Is your feature request related to a problem?

when DM block in the sync stage(e.g. waiting for DDL), the secondsBehindMaster will not be updated.

Describe the feature you'd like

update the secondsBehindMaster even DM block. Don't need to be too precise, just make it bigger and bigger

Describe alternatives you've considered

No response

Teachability, Documentation, Adoption, Migration Strategy

No response
@GMHDBJD GMHDBJD added subject/new-feature Denotes an issue or pull request adding a new feature. area/dm Issues or PRs related to DM. labels Dec 2, 2021
@lance6716
Copy link
Contributor

seems an old issue of secondsBehindMaster but I didn't find it in DM's repo.
cc @glorv

@lance6716 lance6716 added severity/moderate type/bug The issue is confirmed as a bug. and removed subject/new-feature Denotes an issue or pull request adding a new feature. labels Jan 5, 2022
@lance6716
Copy link
Contributor

replaced by #4471 (it has a root cause analysis so I prefer to leave that one open)

@lance6716 lance6716 mentioned this issue Jan 27, 2022
Closed
@Ehco1996
Copy link
Contributor

another request is updating the secondsBehindMaster even DM block. Don't need to be too precise, just make it bigger and bigger

@Ehco1996 Ehco1996 reopened this Jan 27, 2022
@Ehco1996 Ehco1996 self-assigned this Jan 27, 2022
@Ehco1996 Ehco1996 mentioned this issue Jan 27, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue Feb 28, 2022
@Ehco1996
metrics(dm): incr lag metric when syncer blocked (#4496)
557664b 
close #3695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ehco1996 Ehco1996

Labels
area/dm Issues or PRs related to DM. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

metrics(dm): incr lag metric when syncer blocked
3 participants
@lance6716 @Ehco1996 @GMHDBJD