Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binlog inject command supports inject at dml #4260

Open
WizardXiao opened this issue Jan 10, 2022 · 2 comments
Open

binlog inject command supports inject at dml #4260

WizardXiao opened this issue Jan 10, 2022 · 2 comments
Assignees
@WizardXiao
Labels
area/dm Issues or PRs related to DM. subject/new-feature Denotes an issue or pull request adding a new feature. type/feature Issues about a new feature

Comments

@WizardXiao
Copy link
Contributor

WizardXiao commented Jan 10, 2022 •
edited
Loading

Is your feature request related to a problem?

Now binlog inject command just can inject at ddl position, but user need inject at dml when handling error.

Describe the feature you'd like

as title.
@WizardXiao WizardXiao added subject/new-feature Denotes an issue or pull request adding a new feature. area/dm Issues or PRs related to DM. labels Jan 10, 2022
@WizardXiao WizardXiao mentioned this issue Jan 10, 2022
Merged
@okJiang
Copy link
Member

okJiang commented Jan 17, 2022 •
edited
Loading

can we post internal wiki here?

@lance6716 lance6716 added the type/feature Issues about a new feature label Feb 8, 2022
ti-chi-bot pushed a commit that referenced this issue Feb 8, 2022
@WizardXiao
syncer(dm): enhance error handling about add inject at dml event (#4259)
5459951 
close #4260
@WizardXiao
Copy link
Contributor Author

i will add more integration test in next pr. please do not close issue.

@WizardXiao WizardXiao reopened this Feb 8, 2022
@WizardXiao WizardXiao mentioned this issue Mar 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WizardXiao WizardXiao

Labels
area/dm Issues or PRs related to DM. subject/new-feature Denotes an issue or pull request adding a new feature. type/feature Issues about a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lance6716 @okJiang @WizardXiao