Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/version(ticdc): bump max version for release 7.5 #10809

Merged
merged 1 commit into from
Apr 2, 2024
Merged

pkg/version(ticdc): bump max version for release 7.5 #10809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/version/check.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,13 @@ var (
minPDVersion = semver.New("5.1.0-alpha")
// maxPDVersion is the version of the maximum compatible PD.
// Compatible versions are in [minPDVersion, maxPDVersion)
maxPDVersion = semver.New("8.0.0")
maxPDVersion = semver.New("9.0.0")

// MinTiKVVersion is the version of the minimal compatible TiKV.
MinTiKVVersion = semver.New("5.1.0-alpha")
// maxTiKVVersion is the version of the maximum compatible TiKV.
// Compatible versions are in [MinTiKVVersion, maxTiKVVersion)
maxTiKVVersion = semver.New("8.0.0")
maxTiKVVersion = semver.New("9.0.0")

// CaptureInfo.Version is added since v4.0.11,
// we use the minimal release version as default.
Expand All @@ -56,7 +56,7 @@ var (
MinTiCDCVersion = semver.New("6.3.0-alpha")
// MaxTiCDCVersion is the version of the maximum allowed TiCDC version.
// for version `x.y.z`, max allowed `x+2.0.0`
MaxTiCDCVersion = semver.New("8.0.0-alpha")
MaxTiCDCVersion = semver.New("9.0.0-alpha")
)

var versionHash = regexp.MustCompile("-[0-9]+-g[0-9a-f]{7,}(-dev)?")
Expand Down
6 changes: 3 additions & 3 deletions pkg/version/check_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,21 +449,21 @@ func TestCheckTiCDCVersion(t *testing.T) {

versions = map[string]struct{}{
"v6.3.0": {},
"v8.0.0-alpha": {},
"v9.0.0-alpha": {},
}
err = CheckTiCDCVersion(versions)
require.Regexp(t, "TiCDC .* not supported, only support version less than.*", err)

versions = map[string]struct{}{
"v6.3.0": {},
"v8.0.0-master": {},
"v9.0.0-master": {},
}
err = CheckTiCDCVersion(versions)
require.Regexp(t, "TiCDC .* not supported, only support version less than.*", err)

versions = map[string]struct{}{
"v6.3.0": {},
"v8.0.0": {},
"v9.0.0": {},
}
err = CheckTiCDCVersion(versions)
require.Regexp(t, "TiCDC .* not supported, only support version less than.*", err)
Expand Down
Loading