Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new_owner: a owner implement, the owner is a manager of changefeeds #1909

Merged
merged 27 commits into from
Jun 2, 2021
Merged

new_owner: a owner implement, the owner is a manager of changefeeds #1909

merged 27 commits into from
Jun 2, 2021

Conversation

zier-one
Copy link
Contributor

@zier-one zier-one commented Jun 1, 2021 •
edited
Loading

What problem does this PR solve?

a owner implement, the owner is a manager of changefeeds

the owner implements the Reactor interface, Etcd worker driver the owner tick by tick.
the owner's responsible for starting/stopping the changefeed and send admin job to the changefeed

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

leoppro and others added 22 commits May 31, 2021 14:49
update
0dc1690
update
0fe1adb
Merge remote-tracking branch 'pingcap/master' into new_owner_changefeed
137893f
update
f0ab604
update
15f90d6
update
b6af45f
@liuzix
Apply suggestions from code review
9bd73db 
Co-authored-by: Zixiong Liu <[email protected]>
update
f43b565
Update cdc/entry/schema_storage.go
43ab5ed
@liuzix
Apply suggestions from code review
0001b60 
Co-authored-by: Zixiong Liu <[email protected]>
update
2449927
@ti-chi-bot
Merge branch 'master' into new_owner_changefeed
6667717
@ti-chi-bot
Merge branch 'master' into new_owner_changefeed
22f2ada
fix tidy
6b31d42
Merge remote-tracking branch 'origin/new_owner_changefeed' into new_o…
d09309e 
…wner_changefeed
@ti-chi-bot
Merge branch 'master' into new_owner_changefeed
8c96a82
fix test leak
e7695b0
@ti-chi-bot
Merge branch 'master' into new_owner_changefeed
ad391de
fix leak test
6c9bfe3
@ti-chi-bot
Merge branch 'master' into new_owner_changefeed
1ef0b56
update
8ac4349
Merge remote-tracking branch 'pingcap/master' into new_owner_owner
9f4c791
@zier-one zier-one added status/ptal Could you please take a look? needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. labels Jun 1, 2021
@ti-chi-bot ti-chi-bot requested review from amyangfei and overvenus June 1, 2021 09:23
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 1, 2021
amyangfei
amyangfei reviewed Jun 1, 2021
View reviewed changes
cdc/owner/owner.go Outdated Show resolved Hide resolved
cdc/owner/owner.go Show resolved Hide resolved
cdc/owner/owner.go Show resolved Hide resolved
cdc/owner/owner.go Outdated Show resolved Hide resolved
@ti-chi-bot
Copy link
Member

@liuzix: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

@amyangfei: Please use GitHub review feature instead of /lgtm [cancel] when you want to submit review to the pull request.
For how to use GitHub review feature, see also this document provided by GitHub.

For the reason we drop support to the commands, see also this page.
This reply is being used as a temporary reply during the migration of review process and will be removed on July 1st.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 2, 2021
@zier-one
Copy link
Contributor Author

zier-one commented Jun 2, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 91401f4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 2, 2021
@zier-one
Copy link
Contributor Author

zier-one commented Jun 2, 2021

/rebuild

@amyangfei amyangfei merged commit 615e45c into pingcap:master Jun 2, 2021
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 2, 2021
@ti-chi-bot
This is an automated cherry-pick of pingcap#1909
cec9f4a 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 2, 2021
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1912.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 2, 2021
@ti-chi-bot
This is an automated cherry-pick of pingcap#1909
f538bec 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 2, 2021
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1913.

@zier-one zier-one deleted the new_owner_owner branch June 2, 2021 05:10
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 17, 2021
new_owner: a owner implement, the owner is a manager of changefeeds (p…
922a1e9 
…ingcap#1909)
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
new_owner: a owner implement, the owner is a manager of changefeeds (p…
dd9218a 
…ingcap#1909)
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
new_owner: a owner implement, the owner is a manager of changefeeds (p…
dc37905 
…ingcap#1909)
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
new_owner: a owner implement, the owner is a manager of changefeeds (p…
594860d 
…ingcap#1909)
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
new_owner: a owner implement, the owner is a manager of changefeeds (p…
c78c8b5 
…ingcap#1909)
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
new_owner: a owner implement, the owner is a manager of changefeeds (p…
83917fd 
…ingcap#1909)
ti-chi-bot pushed a commit that referenced this pull request Jun 22, 2021
@ti-chi-bot
new_owner: a owner implement, the owner is a manager of changefeeds (#…
91779a1 
…1909)
ti-chi-bot pushed a commit that referenced this pull request Jun 23, 2021
@ti-chi-bot
new_owner: a owner implement, the owner is a manager of changefeeds (#…
5b4f1a1 
…1909)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@liuzix liuzix liuzix approved these changes

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zier-one @liuzix @ti-chi-bot @amyangfei