Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new_owner: switch on the new owner #1927

Merged
merged 20 commits into from
Jun 4, 2021
Merged

new_owner: switch on the new owner #1927

merged 20 commits into from
Jun 4, 2021

Conversation

zier-one
Copy link
Contributor

@zier-one zier-one commented Jun 3, 2021 •
edited
Loading

What problem does this PR solve?

switch on the new owner, it's the last pr of the owner refactor

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Highly available model and core modules refactoring

@ti-chi-bot ti-chi-bot requested review from amyangfei and overvenus June 3, 2021 09:16
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 3, 2021
@zier-one zier-one added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. labels Jun 3, 2021
@zier-one
Copy link
Contributor Author

zier-one commented Jun 3, 2021

/run-all-tests

@zier-one zier-one added status/ptal Could you please take a look? and removed status/wip labels Jun 3, 2021
@zier-one
Copy link
Contributor Author

zier-one commented Jun 3, 2021

/run-all-tests

@zier-one
Copy link
Contributor Author

zier-one commented Jun 3, 2021

/run-all-tests

zier-one
zier-one commented Jun 3, 2021
View reviewed changes
tests/changefeed_error/run.sh Outdated Show resolved Hide resolved
tests/changefeed_finish/run.sh Outdated Show resolved Hide resolved
@zier-one
Copy link
Contributor Author

zier-one commented Jun 3, 2021

/run-all-tests

1 similar comment
@liuzix
Copy link
Contributor

liuzix commented Jun 4, 2021

/run-all-tests

@zier-one
Copy link
Contributor Author

zier-one commented Jun 4, 2021

/run-all-tests

@amyangfei amyangfei added this to the v5.1.0 milestone Jun 4, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 4, 2021
@zier-one
Copy link
Contributor Author

zier-one commented Jun 4, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d6f63dc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2021
@zier-one
Copy link
Contributor Author

zier-one commented Jun 4, 2021

/run-all-tests

@zier-one
Copy link
Contributor Author

zier-one commented Jun 4, 2021

/rebuild

@zier-one
Copy link
Contributor Author

zier-one commented Jun 4, 2021

/run-kafka-tests

1 similar comment
@zier-one
Copy link
Contributor Author

zier-one commented Jun 4, 2021

/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit c534be2 into pingcap:master Jun 4, 2021
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 4, 2021
@ti-chi-bot
This is an automated cherry-pick of pingcap#1927
2124bb0 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 4, 2021
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1936.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 4, 2021
@ti-chi-bot
This is an automated cherry-pick of pingcap#1927
0531c07 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1937.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 4, 2021
Closed
@zier-one zier-one deleted the new_owner_switch_on branch June 4, 2021 14:13
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 17, 2021
new_owner: switch on the new owner (pingcap#1927)
5b16c77
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
new_owner: switch on the new owner (pingcap#1927)
75a9e96
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
new_owner: switch on the new owner (pingcap#1927)
77e8d1f
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
new_owner: switch on the new owner (pingcap#1927)
732fbc3
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
new_owner: switch on the new owner (pingcap#1927)
90a0fef
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
new_owner: switch on the new owner (pingcap#1927)
64eee8c
ti-chi-bot pushed a commit that referenced this pull request Jun 22, 2021
@ti-chi-bot
new_owner: switch on the new owner (#1927)
ff275ef
ti-chi-bot pushed a commit that referenced this pull request Jun 23, 2021
@ti-chi-bot
new_owner: switch on the new owner (#1927)
9f46b7b
@amyangfei amyangfei mentioned this pull request Dec 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@liuzix liuzix liuzix approved these changes

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
v5.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zier-one @liuzix @ti-chi-bot @amyangfei