Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner: fix the owner panic #1964

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Conversation

zier-one
Copy link
Contributor

@zier-one zier-one commented Jun 7, 2021

What problem does this PR solve?

fix the owner panic, fix #1956

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@ti-chi-bot ti-chi-bot requested review from amyangfei and overvenus June 7, 2021 03:51
@zier-one zier-one added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. status/ptal Could you please take a look? labels Jun 7, 2021
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 7, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 7, 2021
@amyangfei amyangfei added this to the v5.1.0 milestone Jun 7, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 7, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7b3ee43

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 7, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1964 (7b3ee43) into master (a1067a0) will increase coverage by 0.1991%.
The diff coverage is 66.1549%.

@@               Coverage Diff                @@
##             master      #1964        +/-   ##
================================================
+ Coverage   53.8746%   54.0737%   +0.1991%     
================================================
  Files           155        164         +9     
  Lines         16479      17404       +925     
================================================
+ Hits           8878       9411       +533     
- Misses         6652       6986       +334     
- Partials        949       1007        +58     

@ti-chi-bot ti-chi-bot merged commit 83636c6 into pingcap:master Jun 7, 2021
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 7, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1965.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 7, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1966.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1967.

amyangfei pushed a commit that referenced this pull request Jun 7, 2021
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 17, 2021
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
zier-one pushed a commit to zier-one/ticdc that referenced this pull request Jun 22, 2021
ti-chi-bot pushed a commit that referenced this pull request Jun 22, 2021
ti-chi-bot pushed a commit that referenced this pull request Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdc server panic with new owner
5 participants