Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix unstable integration_test gc_safepoint #2717

Merged
merged 3 commits into from
Sep 2, 2021
Merged

tests: fix unstable integration_test gc_safepoint #2717

merged 3 commits into from
Sep 2, 2021

Conversation

CharlesCheung96
Copy link
Contributor

What problem does this PR solve?

close #2653

What is changed and how it works?

record start_safepoint before check_safepoint_forward

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change

Side effects

None

Related changes

None

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 2, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 2, 2021
@CLAassistant
Copy link

CLAassistant commented Sep 2, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Sep 2, 2021
@ti-chi-bot
Copy link
Member

Welcome @CharlesCheung96!

It looks like this is your first PR to pingcap/ticdc 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/ticdc. 😃

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 2, 2021
@amyangfei
Copy link
Contributor

/run-integration-tests

1 similar comment
@amyangfei
Copy link
Contributor

/run-integration-tests

@Rustin170506
Copy link
Member

/run-all-tests

@Rustin170506
Copy link
Member

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
CharlesCheung seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@CharlesCheung96 Could you please sign the cla?

@amyangfei amyangfei added needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. component/test Unit tests and integration tests component. labels Sep 2, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 2, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 2, 2021
@Rustin170506
Copy link
Member

/run-all-tests

@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8abf1cb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 2, 2021
@amyangfei
Copy link
Contributor

/run-kafka-tests

@Rustin170506 Rustin170506 mentioned this pull request Sep 2, 2021
Merged
@Rustin170506
Copy link
Member

/run-integration-tests
/run-kafka-tests

@CharlesCheung96
Copy link
Contributor Author

/retest

@CharlesCheung96
Copy link
Contributor Author

/run-integration-tests
/run-kafka-tests

ti-chi-bot referenced this pull request in ti-community-infra/tichi Sep 2, 2021
@Rustin170506
fix(merge): If the commit hash is not found, check each commit (#719)
408e617 
If the commit hash is not found, check each commit.

A bad case: https://github.com/pingcap/ticdc/pull/2717
@CharlesCheung96
Copy link
Contributor Author

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@Rustin170506
Copy link
Member

/run-kafka-tests

@Rustin170506
Copy link
Member

/run-kafka-tests /tikv=pr/10786

@CharlesCheung96
Copy link
Contributor Author

/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit ec0e1d0 into pingcap:master Sep 2, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 2, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2737.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2738.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 2, 2021
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Sep 2, 2021
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#2717
1bb91c1 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 2, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2739.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Sep 2, 2021
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#2717
ab94db7 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2740.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 2, 2021
Merged
@nongfushanquan nongfushanquan added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 6, 2021
ti-chi-bot added a commit that referenced this pull request Sep 6, 2021
@ti-chi-bot
tests: fix unstable integration_test gc_safepoint (#2717) (#2739)
137588c
ti-chi-bot added a commit that referenced this pull request Sep 6, 2021
@ti-chi-bot
tests: fix unstable integration_test gc_safepoint (#2717) (#2740)
0ebf717
ti-chi-bot added a commit that referenced this pull request Sep 7, 2021
@ti-chi-bot
tests: fix unstable integration_test gc_safepoint (#2717) (#2738)
4d48983
ti-chi-bot added a commit that referenced this pull request Sep 8, 2021
@ti-chi-bot
tests: fix unstable integration_test gc_safepoint (#2717) (#2737)
ad02967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@Rustin170506 Rustin170506 Rustin170506 approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/test Unit tests and integration tests component. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

check_safepoint_forward in integration test gc_safepoint is not correct
6 participants
@CharlesCheung96 @ti-chi-bot @CLAassistant @amyangfei @Rustin170506 @nongfushanquan