Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink: fix codec json encoding with non binary string (#2764) #2784

Merged
merged 7 commits into from
Sep 22, 2021
Merged

sink: fix codec json encoding with non binary string (#2764) #2784

merged 7 commits into from
Sep 22, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2764

What problem does this PR solve?

Close #2758

Note we still don't known in which scenario the column value is string instead of []byte, need more investigation.

What is changed and how it works?

The column value type of mysql.TypeString, mysql.TypeVarString, mysql.TypeVarchar could be either string or []byte, we should consider both of these two types when converting a row column value to json encoding.

Check List

Tests

  • Unit test
  • Integration test

Release note 

Fix json encoding could panic when processing a string type value in some cases.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 9, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 9, 2021
Merged
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. labels Sep 9, 2021
@amyangfei amyangfei added this to the v5.2.1 milestone Sep 10, 2021
@amyangfei amyangfei added the release-blocker This issue blocks a release. Please solve it ASAP. label Sep 10, 2021
@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 10, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 9b4f124

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 10, 2021
@amyangfei
Copy link
Contributor

/run-integration-tests
/run-leak-tests
/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

8 similar comments
@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

7 similar comments
@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests
/run-unit-tests

@amyangfei amyangfei modified the milestones: v5.2.1, v5.2.2 Sep 18, 2021
@amyangfei
Copy link
Contributor

/run-integration-tests

1 similar comment
@amyangfei
Copy link
Contributor

/run-integration-tests

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit a933190 into pingcap:release-5.2 Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuzix liuzix Awaiting requested review from liuzix

@overvenus overvenus Awaiting requested review from overvenus

Assignees

@amyangfei amyangfei

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-blocker This issue blocks a release. Please solve it ASAP. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR.
Projects
None yet
Milestone
v5.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @amyangfei @nongfushanquan