-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add test case to cover varchar default value #2799
tests: add test case to cover varchar default value #2799
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
054ed84
to
9019ced
Compare
/run-all-tests |
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #2799 +/- ##
================================================
+ Coverage 55.4760% 57.1648% +1.6887%
================================================
Files 165 180 +15
Lines 19841 18877 -964
================================================
- Hits 11007 10791 -216
+ Misses 7786 7097 -689
+ Partials 1048 989 -59 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6a33515
|
/run-leak-tests |
/run-kafka-tests |
/run-kafka-tests |
/run-kafka-tests |
2 similar comments
/run-kafka-tests |
/run-kafka-tests |
In response to a cherrypick label: new pull request created: #2892. |
In response to a cherrypick label: new pull request created: #2893. |
In response to a cherrypick label: new pull request created: #2894. |
In response to a cherrypick label: new pull request created: #2895. |
What problem does this PR solve?
Add test case to cover #2758
What is changed and how it works?
The case works as follows
v1
, however when we decode these rows, we should use the new table schema (which has the column ofv1
, this scenario doesn't break the constraint of online DDL). Since the column doesn't exist, the tidb library will fill in a default value, which is astring
type here. This is why we can get either[]byte
or astring
of a column.Value.Check List
Tests
Release note