-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdc/sorter: make unified sorter cgroup aware (#3436) #3438
cdc/sorter: make unified sorter cgroup aware (#3436) #3438
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 088c11c
|
/run-kafka-integration-test |
Codecov Report
@@ Coverage Diff @@
## release-5.2 #3438 +/- ##
================================================
Coverage ? 53.9122%
================================================
Files ? 192
Lines ? 21535
Branches ? 0
================================================
Hits ? 11610
Misses ? 8827
Partials ? 1098 |
This is an automated cherry-pick of #3436
What problem does this PR solve?
It fixes an OOM issue where memory limited by cgroup is smaller
than physical memory.
Note this patch only recognizes container cgroup, it may still
OOM when the cgroup is set by systemd or manually.
Cc https://github.com/pingcap/ticdc/issues/1798
Check List
Tests
--sink-uri="mysql://xx:xx@MYSQLIP:3306/" -c "mysql37"
--start-ts=$(( $(pd-ctl -u http://PDIP service-gc-safepoint | jq '.service_gc_safe_points[] | select(.service_id == "gc_worker") | .safe_point') + 1000 ))
--no-confirm --sort-engine=unified
OOM log in demsg
Left: master
Right: this PR
Related changes
Release note