cdc/sorter: make unified sorter cgroup aware (#3436) #3440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #3436
What problem does this PR solve?
It fixes an OOM issue where memory limited by cgroup is smaller
than physical memory.
Note this patch only recognizes container cgroup, it may still
OOM when the cgroup is set by systemd or manually.
Cc https://github.com/pingcap/ticdc/issues/1798
Check List
Tests
--sink-uri="mysql://xx:xx@MYSQLIP:3306/" -c "mysql37"
--start-ts=$(( $(pd-ctl -u http://PDIP service-gc-safepoint | jq '.service_gc_safe_points[] | select(.service_id == "gc_worker") | .safe_point') + 1000 ))
--no-confirm --sort-engine=unified
OOM log in demsg
Left: master
Right: this PR
Related changes
Release note