Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc/sink: adjust kafka initialization logic (#3192) #3565

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 22, 2021

This is an automated cherry-pick of #3192

What problem does this PR solve?

close #3337

This is part work of making Kafka GA. Contain the following:

  • Refine the logic of creating topic
  • Make some variable become a field of the Config, which would be helpful if we would support one producer per topic in the future since this group producer parameters together.
  • Bugfix
    • If auto-create-topic disable by the user, the partition count will not be checked.
    • before create the topic, make sure broker's message.max.bytes not less than max-message-bytes

What is changed and how it works?

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Screen Shot 2021-11-09 at 13 24 36

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note

`None`.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved component/sink Sink component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Nov 22, 2021
@3AceShowHand 3AceShowHand added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 22, 2021
@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 22, 2021
@3AceShowHand
Copy link
Contributor

/run-all-tests

@3AceShowHand
Copy link
Contributor

/run-all-tests

@3AceShowHand
Copy link
Contributor

/run-integration-tests
/run-kafka-integration-tests
/run-unit-tests
/run-leak-tests

@3AceShowHand
Copy link
Contributor

/run-kafka-integration-test

@3AceShowHand
Copy link
Contributor

/run-all-tests

@codecov-commenter
Copy link

Codecov Report

Merging #3565 (b0c0c96) into release-4.0 (753073a) will increase coverage by 3.1375%.
The diff coverage is 66.6219%.

@@                 Coverage Diff                 @@
##           release-4.0      #3565        +/-   ##
===================================================
+ Coverage      53.7661%   56.9036%   +3.1375%     
===================================================
  Files              153        165        +12     
  Lines            15958      19649      +3691     
===================================================
+ Hits              8580      11181      +2601     
- Misses            6475       7417       +942     
- Partials           903       1051       +148     

@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: b0c0c96

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 23, 2021
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@3AceShowHand
Copy link
Contributor

/run-verify-ci

1 similar comment
@3AceShowHand
Copy link
Contributor

/run-verify-ci

@ti-chi-bot ti-chi-bot merged commit 95d2ebc into pingcap:release-4.0 Nov 23, 2021
@zhouqiang-cl zhouqiang-cl added this to the v4.0.16 milestone Dec 6, 2021
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/sink Sink component. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants