-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdc/sink: adjust kafka initialization logic (#3192) #3565
cdc/sink: adjust kafka initialization logic (#3192) #3565
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
/run-all-tests |
/run-integration-tests |
/run-kafka-integration-test |
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #3565 +/- ##
===================================================
+ Coverage 53.7661% 56.9036% +3.1375%
===================================================
Files 153 165 +12
Lines 15958 19649 +3691
===================================================
+ Hits 8580 11181 +2601
- Misses 6475 7417 +942
- Partials 903 1051 +148 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b0c0c96
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-verify-ci |
1 similar comment
/run-verify-ci |
This is an automated cherry-pick of #3192
What problem does this PR solve?
close #3337
This is part work of making Kafka GA. Contain the following:
Config
, which would be helpful if we would support one producer per topic in the future since this group producer parameters together.auto-create-topic
disable by the user, the partition count will not be checked.message.max.bytes
not less thanmax-message-bytes
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release note