ticdc/kvclient: make multiple cdc kv clients share one RegionCache (#3464) #3636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #3464
What problem does this PR solve?
issue 3208
Considering the following test:
sysbench prepare
command.Optimization Result:
Before optimization: In
go pprof goroutine
result, we can see 10 goroutines associated with*RegionCache).asyncCheckAndResolveLoop
.After optimization: In
go pprof goroutine
result, we can see 1 goroutines associated with*RegionCache).asyncCheckAndResolveLoop
.Note: Several goroutines created by tikv/client-go may be visible to us in
go pprof goroutine
result as well.What is changed and how it works?
Use a server-level RegionCache instead of calling
tikv.NewRegionCache
every time a CDCClient is created. By this way, we can use exactly one goroutine for(*RegionCache).asyncCheckAndResolveLoop
.Check List
Tests
Release note