-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcd/client (ticdc): Prevent revision in WatchWitchChan fallback. (#3851) #3926
etcd/client (ticdc): Prevent revision in WatchWitchChan fallback. (#3851) #3926
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-5.2 #3926 +/- ##
================================================
Coverage ? 57.3773%
================================================
Files ? 194
Lines ? 19431
Branches ? 0
================================================
Hits ? 11149
Misses ? 7314
Partials ? 968 |
/run-integration-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 0ce7ad9
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-kafka-integration-tests |
This is an automated cherry-pick of #3851
What problem does this PR solve?
ref: #3615
ref: #4549
Prevent revision rollback.
Note: Before this PR merge, the lastRevision in WatchWitchChan is initialized to 0. When the watchCh is reset since there has no message been received , revision will be set to 0+1.
This may result in receiving some messages that do not need to be received, lead to a certain extend of performance loss, but it will not cause any correctness problems.
What is changed and how it works?
Clear and simple in code.
Check List
Tests
Related changes
Release note