-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openapi(dm): change url path from config to templates #4040
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #4040 +/- ##
================================================
- Coverage 57.0741% 55.1858% -1.8884%
================================================
Files 478 486 +8
Lines 56551 60010 +3459
================================================
+ Hits 32276 33117 +841
- Misses 20978 23532 +2554
- Partials 3297 3361 +64 |
/run-dm-integration-tests |
could you please take another look for this pr ? thanks 🧡🧡🧡 this PR just change the url path / variable from /cc @GMHDBJD @lance6716 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 966b3aa
|
@Ehco1996: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-integration-test |
2 similar comments
/run-integration-test |
/run-integration-test |
What problem does this PR solve?
part of https://github.com/pingcap/ticdc/issues/3583
What is changed and how it works?
as title , only path and var name changed, no new logic
Check List
Tests
Code changes
Side effects
Related changes
Release note