Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi(dm): change url path from config to templates #4040

Merged
merged 6 commits into from
Jan 5, 2022
Merged

openapi(dm): change url path from config to templates #4040

merged 6 commits into from
Jan 5, 2022

Conversation

Ehco1996
Copy link
Contributor

What problem does this PR solve?

part of https://github.com/pingcap/ticdc/issues/3583

What is changed and how it works?

as title , only path and var name changed, no new logic

Check List

Tests

  • Unit test
  • Integration test
  • No code

Code changes

  • Has exported function/method change
  • Has persistent data change

Side effects

Related changes

Release note

`None`.

@Ehco1996 Ehco1996 added the area/dm Issues or PRs related to DM. label Dec 23, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • okJiang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

Merging #4040 (6bab0ae) into master (3873d39) will decrease coverage by 1.8883%.
The diff coverage is 66.8795%.

Flag Coverage Δ
cdc 58.6920% <66.8493%> (+0.4554%) ⬆️
dm 52.2183% <100.0000%> (-3.8163%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4040        +/-   ##
================================================
- Coverage   57.0741%   55.1858%   -1.8884%     
================================================
  Files           478        486         +8     
  Lines         56551      60010      +3459     
================================================
+ Hits          32276      33117       +841     
- Misses        20978      23532      +2554     
- Partials       3297       3361        +64     

@Ehco1996
Copy link
Contributor Author

/run-dm-integration-tests

@Ehco1996
Copy link
Contributor Author

could you please take another look for this pr ? thanks 🧡🧡🧡

this PR just change the url path / variable from task configs to task templates , no new logic

/cc @GMHDBJD @lance6716

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 31, 2021
@Ehco1996
Copy link
Contributor Author

Ehco1996 commented Jan 4, 2022

ping @GMHDBJD @okJiang 😬😬😬

this PR just change the url path / variable from task configs to task templates , no new logic

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 4, 2022
@Ehco1996
Copy link
Contributor Author

Ehco1996 commented Jan 4, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 966b3aa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 4, 2022
@ti-chi-bot
Copy link
Member

@Ehco1996: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Ehco1996
Copy link
Contributor Author

Ehco1996 commented Jan 5, 2022

/run-integration-test

2 similar comments
@Ehco1996
Copy link
Contributor Author

Ehco1996 commented Jan 5, 2022

/run-integration-test

@Ehco1996
Copy link
Contributor Author

Ehco1996 commented Jan 5, 2022

/run-integration-test

@ti-chi-bot ti-chi-bot merged commit 795bd6e into pingcap:master Jan 5, 2022
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants