Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(ticdc): add tests for kafka max-message-bytes (#4125) #4153

Merged
merged 5 commits into from
Feb 7, 2022
Merged

tests(ticdc): add tests for kafka max-message-bytes (#4125) #4153

merged 5 commits into from
Feb 7, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4125

What problem does this PR solve?

Issue Number: close #4124

What is changed and how it works?

add tests for kafka max-message-bytes

  • When Topic exists
  • When Topic does not exist

Check List

Tests

  • Integration test

Code changes

None

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note 

None

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. area/ticdc Issues or PRs related to TiCDC. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Dec 30, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 30, 2021
Merged
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2021 •
edited
Loading

Codecov Report

Merging #4153 (ae096b0) into release-4.0 (753073a) will increase coverage by 8.2169%.
The diff coverage is 74.3938%.

@@                 Coverage Diff                 @@
##           release-4.0      #4153        +/-   ##
===================================================
+ Coverage      53.7661%   61.9830%   +8.2169%     
===================================================
  Files              153        162         +9     
  Lines            15958      16782       +824     
===================================================
+ Hits              8580      10402      +1822     
+ Misses            6475       5485       -990     
+ Partials           903        895         -8

@overvenus overvenus added this to the v4.0.17 milestone Jan 11, 2022
@Rustin170506
Copy link
Member

/run-all-tests

@Rustin170506
Copy link
Member

blocked by #4059

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2022
@Rustin170506
Copy link
Member

/unhold

/merge

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2022
@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 1d1a247

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 7, 2022
@Rustin170506
Copy link
Member

/run-all-tests

@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 7, 2022
@Rustin170506
Copy link
Member

/run-unit-test

@Rustin170506
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Feb 7, 2022
@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: ae096b0

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 7, 2022
@Rustin170506
Copy link
Member

/merge

@Rustin170506
Copy link
Member

/run-unit-test
/run-leak-test

@Rustin170506
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2022
@ti-chi-bot ti-chi-bot merged commit 56edbd7 into pingcap:release-4.0 Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Rustin170506 Rustin170506

Labels
area/ticdc Issues or PRs related to TiCDC. cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Milestone
v4.0.17
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @codecov-commenter @Rustin170506 @overvenus @nongfushanquan