tests(ticdc): Migrate several test cases to testify #4199

zhaoxinyu · 2022-01-04T03:05:47Z

What problem does this PR solve?

Issue Number: close #2901
Issue Number: close #2902
Issue Number: close #4200

What is changed and how it works?

Migrate test cases under cdc/owner, cdc/processor and pkg/orchestrator.
Add test case for call back function in feedStateManager.handleError().

Check List

Tests

Unit test

Release note

None

ti-chi-bot · 2022-01-04T03:05:48Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

asddongmen
overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ben1009 · 2022-01-04T03:19:24Z

cdc/owner/changefeed.go

@@ -514,6 +514,9 @@ func (c *changefeed) asyncExecDDL(ctx cdcContext.Context, job *timodel.Job) (don
 func (c *changefeed) updateStatus(currentTs int64, checkpointTs, resolvedTs model.Ts) {
 	c.state.PatchStatus(func(status *model.ChangeFeedStatus) (*model.ChangeFeedStatus, bool, error) {
 		changed := false
+		if status == nil {


any ut cover the change?

ben1009 · 2022-01-04T03:21:33Z

cdc/owner/feed_state_manager.go

@@ -149,6 +149,9 @@ func (m *feedStateManager) handleAdminJob() (jobsPending bool) {
 		m.patchState(model.StateNormal)
 		// remove error history to make sure the changefeed can running in next tick
 		m.state.PatchInfo(func(info *model.ChangeFeedInfo) (*model.ChangeFeedInfo, bool, error) {
+			if info == nil {


any ut for the change?

ben1009 · 2022-01-04T03:30:33Z

[2022-01-04T03:13:27.457Z] FAIL github.com/pingcap/tiflow/pkg/orchestrator 40.315s

zhaoxinyu · 2022-01-04T03:32:27Z

[2022-01-04T03:13:27.457Z] FAIL github.com/pingcap/tiflow/pkg/orchestrator 40.315s

The test failure is caused by accessing a removed test dir. I have fixed it.

ben1009 · 2022-01-05T03:13:38Z

seems the fail test is fixing #4175

zhaoxinyu · 2022-01-05T03:30:47Z

seems the fail test is fixing #4175

I will add unit tests for the aforementioned callback functions and trigger the dm-unit-test again.

codecov-commenter · 2022-01-20T10:48:53Z

Codecov Report

Merging #4199 (fabed46) into master (ab62e6b) will decrease coverage by 0.1283%.
The diff coverage is 45.8152%.

Flag	Coverage Δ
cdc	`59.2691% <54.5082%> (-0.3468%)`	⬇️
dm	`52.1097% <38.5925%> (+0.0441%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4199        +/-   ##
================================================
- Coverage   55.5183%   55.3900%   -0.1284%     
================================================
  Files           495        495                
  Lines         61151      61280       +129     
================================================
- Hits          33950      33943         -7     
- Misses        23789      23935       +146     
+ Partials       3412       3402        -10

overvenus · 2022-01-25T15:59:11Z

/merge

ti-chi-bot · 2022-01-25T15:59:14Z

This pull request has been accepted and is ready to merge.

Commit hash: 8458675

close pingcap#2901

zhaoxinyu added 2 commits December 28, 2021 17:49

migrate some test cases to testify

95f0592

modify test cases

c48fd06

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 4, 2022

zhaoxinyu requested review from asddongmen, overvenus, Rustin170506 and ben1009 January 4, 2022 03:06

ben1009 reviewed Jan 4, 2022

View reviewed changes

zhaoxinyu added 3 commits January 4, 2022 11:47

fix the test dir accessing problem

e8212f0

fix a lint problem

50a6b4a

Merge branch 'master' into migrate_test_cases

d4f937f

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2022

fix a merge conflict

69a2f86

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2022

zhaoxinyu force-pushed the migrate_test_cases branch from 2642667 to 69a2f86 Compare January 20, 2022 10:30

Merge branch 'master' into migrate_test_cases

ba938bd

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2022

zhaoxinyu added 2 commits January 20, 2022 22:40

fix a lint problem

fabed46

modify some unit tests under cdc/owner

8458675

asddongmen approved these changes Jan 25, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 25, 2022

overvenus approved these changes Jan 25, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 25, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 25, 2022

ti-chi-bot added 3 commits January 25, 2022 23:59

Merge branch 'master' into migrate_test_cases

de5a476

Merge branch 'master' into migrate_test_cases

330ef30

Merge branch 'master' into migrate_test_cases

1edaa51

ti-chi-bot merged commit 03c5232 into pingcap:master Jan 26, 2022

CharlesCheung96 pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 17, 2022

tests(ticdc): Migrate several test cases to testify (pingcap#4199)

c9a0daa

close pingcap#2901

CharlesCheung96 mentioned this pull request Feb 17, 2022

etcd/client(ticdc): add retry operation for etcd transaction api (#4248) (#4474) #4533

Merged

CharlesCheung96 pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 24, 2022

tests(ticdc): Migrate several test cases to testify (pingcap#4199)

fa509a3

close pingcap#2901

CharlesCheung96 pushed a commit to ti-chi-bot/tiflow that referenced this pull request Apr 28, 2022

tests(ticdc): Migrate several test cases to testify (pingcap#4199)

353aea4

close pingcap#2901

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests(ticdc): Migrate several test cases to testify #4199

tests(ticdc): Migrate several test cases to testify #4199

zhaoxinyu commented Jan 4, 2022 •

edited

Loading

ti-chi-bot commented Jan 4, 2022 •

edited

Loading

ben1009 Jan 4, 2022

ben1009 Jan 4, 2022

ben1009 commented Jan 4, 2022

zhaoxinyu commented Jan 4, 2022 •

edited

Loading

ben1009 commented Jan 5, 2022

zhaoxinyu commented Jan 5, 2022

codecov-commenter commented Jan 20, 2022 •

edited

Loading

overvenus commented Jan 25, 2022

ti-chi-bot commented Jan 25, 2022

tests(ticdc): Migrate several test cases to testify #4199

tests(ticdc): Migrate several test cases to testify #4199

Conversation

zhaoxinyu commented Jan 4, 2022 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Jan 4, 2022 • edited Loading

ben1009 Jan 4, 2022

Choose a reason for hiding this comment

ben1009 Jan 4, 2022

Choose a reason for hiding this comment

ben1009 commented Jan 4, 2022

zhaoxinyu commented Jan 4, 2022 • edited Loading

ben1009 commented Jan 5, 2022

zhaoxinyu commented Jan 5, 2022

codecov-commenter commented Jan 20, 2022 • edited Loading

Codecov Report

overvenus commented Jan 25, 2022

ti-chi-bot commented Jan 25, 2022

zhaoxinyu commented Jan 4, 2022 •

edited

Loading

ti-chi-bot commented Jan 4, 2022 •

edited

Loading

zhaoxinyu commented Jan 4, 2022 •

edited

Loading

codecov-commenter commented Jan 20, 2022 •

edited

Loading