Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(dm): fix datarace for testSyncerSuite.TestRun #4305

Merged
merged 3 commits into from
Jan 18, 2022
Merged

test(dm): fix datarace for testSyncerSuite.TestRun #4305

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4b4c72
test(dm): fix datarace for testSyncerSuite.TestRun
Ehco1996 Jan 12, 2022
b9fe643
Merge branch 'master' into fix-4280
Ehco1996 Jan 18, 2022
300ec7e
Merge branch 'master' into fix-4280
ti-chi-bot Jan 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dm/syncer/syncer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,6 +957,7 @@ func (s *testSyncerSuite) TestRun(c *C) {
}

cancel()
<-resultCh // wait for the process to finish
// when syncer exit Run(), will flush job
syncer.Pause()

Expand Down Expand Up @@ -1023,6 +1024,7 @@ func (s *testSyncerSuite) TestRun(c *C) {
testJobs.RUnlock()

cancel()
<-resultCh // wait for the process to finish
syncer.Close()
c.Assert(syncer.isClosed(), IsTrue)

Expand Down