Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(dm): try fix testMaster.TestStartTaskWithRemoveMeta #4306

Closed
wants to merge 2 commits into from
Closed

test(dm): try fix testMaster.TestStartTaskWithRemoveMeta #4306

wants to merge 2 commits into from

Conversation

Ehco1996
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #4168

What is changed and how it works?

the old test logic mute startTask err when chekcer failed, we should not do this, but i still not found why startTask failed

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note

`None`.

@Ehco1996 Ehco1996 added the area/dm Issues or PRs related to DM. label Jan 12, 2022
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 12, 2022
@lance6716
Copy link
Contributor

ping @Ehco1996

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2022

Codecov Report

Merging #4306 (c5d025d) into master (08da001) will increase coverage by 0.2530%.
The diff coverage is 52.1359%.

Flag Coverage Δ
cdc 59.2912% <63.4101%> (+0.6464%) ⬆️
dm 52.1870% <39.5897%> (-0.0676%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4306        +/-   ##
================================================
+ Coverage   55.1722%   55.4253%   +0.2530%     
================================================
  Files           485        495        +10     
  Lines         59829      60918      +1089     
================================================
+ Hits          33009      33764       +755     
- Misses        23484      23765       +281     
- Partials       3336       3389        +53     

@Ehco1996
Copy link
Contributor Author

Close for now, still no way to reproduce locally

@Ehco1996 Ehco1996 closed this Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. do-not-merge/needs-triage-completed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DM TestStartTaskWithRemoveMeta
4 participants