Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics(cdc): fix mq sink write row count metrics. (#4192) #4322

Merged
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
def4d82
fix the txn_batch_size metric inaccuracy bug when the sink target is MQ
zhaoxinyu Nov 24, 2021
630ec41
address comments
zhaoxinyu Dec 1, 2021
7e584b1
add comments for exported functions
zhaoxinyu Dec 1, 2021
c3c0ac5
fix the compiling problem
zhaoxinyu Dec 9, 2021
db3d42e
workerpool: limit the rate to output deadlock warning (#3775) (#3799)
ti-chi-bot Dec 10, 2021
eaa63a2
metrics: add changefeed checkepoint catch-up ETA (#3300) (#3311)
ti-chi-bot Dec 10, 2021
ef9a4fe
pkg,cdc: do not use log package (#3902) (#3939)
ti-chi-bot Dec 17, 2021
3c36fc0
*: rename repo from pingcap/ticdc to pingcap/tiflow (#3957)
amyangfei Dec 20, 2021
d93f48e
kvclient(ticdc): fix kvclient takes too long time to recover (#3612) …
ti-chi-bot Dec 20, 2021
cff3be9
tz (ticdc): fix timezone error (#3887) (#3910)
ti-chi-bot Dec 20, 2021
276e74c
http_*: add log for http api and refine the err handle logic (#2997) …
ti-chi-bot Dec 20, 2021
47f28b0
ticdc/alert: add no owner alert rule (#3809) (#3831)
ti-chi-bot Dec 20, 2021
bb8b7c1
etcd_worker: batch etcd patch (#3277) (#3393)
ti-chi-bot Dec 20, 2021
4915083
ticdc/owner: Fix ddl special comment syntax error (#3845) (#3977)
ti-chi-bot Dec 22, 2021
93020bb
Clean old owner and old processor in release 5.2 branch (#4019)
asddongmen Dec 23, 2021
2ac75e4
tests(ticdc): set up the sync diff output directory correctly (#3725)…
ti-chi-bot Dec 24, 2021
149f3f4
owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980…
ti-chi-bot Dec 24, 2021
28614b3
config(ticdc): Fix old value configuration check for maxwell protocol…
ti-chi-bot Dec 24, 2021
6476b37
ticdc/processor: Fix backoff base delay misconfiguration (#3992) (#4027)
ti-chi-bot Dec 24, 2021
7e39a2f
sink(ticdc): cherry pick sink bug fix to release 5.2 (#4083) (#4119)
ti-chi-bot Dec 30, 2021
6228225
metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038…
ti-chi-bot Dec 30, 2021
75957ec
kv(ticdc): reduce eventfeed rate limited log (#4072) (#4110)
ti-chi-bot Dec 30, 2021
9f84f95
This is an automated cherry-pick of #4192
3AceShowHand Jan 4, 2022
4ca5c72
http_api (ticdc): fix http api 'get processor' panic. (#4117) (#4122)
ti-chi-bot Jan 10, 2022
03a292e
cdc/sink: adjust kafka initialization logic (#3192) (#3568)
ti-chi-bot Jan 12, 2022
9a99748
sink (ticdc): fix a deadlock due to checkpointTs fall back in sinkNod…
ti-chi-bot Jan 12, 2022
f65fa37
This is an automated cherry-pick of #4192
3AceShowHand Jan 4, 2022
342afe7
Merge branch 'release-5.2' into cherry-pick-4192-to-release-5.2
3AceShowHand Jan 17, 2022
c6b02f9
fix conflicts.
3AceShowHand Jan 18, 2022
e0bfd11
fix.
3AceShowHand Jan 18, 2022
2ede768
fix conflicts.
3AceShowHand Jan 18, 2022
098a9c5
fix conflicts.
3AceShowHand Jan 18, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
pkg,cdc: do not use log package (#3902) (#3939)
ti-chi-bot authored and 3AceShowHand committed Jan 13, 2022
commit ef9a4fe2b70b524eb4af7d51c02bfd16a214e15d
13 changes: 13 additions & 0 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -2,3 +2,16 @@ linters:
enable:
- unconvert
- unparam
- depguard

linters-settings:
depguard:
list-type: blacklist
include-go-root: false
packages:
- log
- github.com/juju/errors
packages-with-error-message:
# specify an error message to output when a blacklisted package is used
- log: "logging is allowed only by pingcap/log"
- github.com/juju/errors: "error handling is allowed only by pingcap/errors"
2 changes: 1 addition & 1 deletion cdc/processor/pipeline/mounter.go
Original file line number Diff line number Diff line change
@@ -15,12 +15,12 @@ package pipeline

import (
"context"
"log"
"sync"
"time"

"github.com/edwingeng/deque"
"github.com/pingcap/failpoint"
"github.com/pingcap/log"
"github.com/pingcap/ticdc/cdc/model"
"github.com/pingcap/ticdc/pkg/notify"
"github.com/pingcap/ticdc/pkg/pipeline"
3 changes: 2 additions & 1 deletion cdc/puller/frontier/list.go
Original file line number Diff line number Diff line change
@@ -16,11 +16,12 @@ package frontier
import (
"bytes"
"fmt"
"log"
"math"
"strings"

_ "unsafe" // required by go:linkname

"github.com/pingcap/log"
)

const (
2 changes: 1 addition & 1 deletion cdc/sink/codec/canal.go
Original file line number Diff line number Diff line change
@@ -15,12 +15,12 @@ package codec

import (
"fmt"
"log"
"strconv"
"strings"

"github.com/golang/protobuf/proto" // nolint:staticcheck
"github.com/pingcap/errors"
"github.com/pingcap/log"
mm "github.com/pingcap/parser/model"
"github.com/pingcap/parser/mysql"
parser_types "github.com/pingcap/parser/types"
2 changes: 1 addition & 1 deletion cdc/sink/common/flow_control.go
Original file line number Diff line number Diff line change
@@ -14,12 +14,12 @@
package common

import (
"log"
"sync"
"sync/atomic"

"github.com/edwingeng/deque"
"github.com/pingcap/errors"
"github.com/pingcap/log"
cerrors "github.com/pingcap/ticdc/pkg/errors"
"go.uber.org/zap"
)
2 changes: 1 addition & 1 deletion integration/tests/case_date_time.go
Original file line number Diff line number Diff line change
@@ -15,9 +15,9 @@ package tests

import (
"errors"
"log"
"time"

"github.com/pingcap/log"
"github.com/pingcap/ticdc/integration/framework"
"github.com/pingcap/ticdc/integration/framework/avro"
"github.com/pingcap/ticdc/integration/framework/canal"
8 changes: 3 additions & 5 deletions pkg/context/context.go
Original file line number Diff line number Diff line change
@@ -15,16 +15,14 @@ package context

import (
"context"
"log"
"time"

"github.com/pingcap/ticdc/pkg/pdtime"

"github.com/pingcap/ticdc/pkg/version"

"github.com/pingcap/log"
"github.com/pingcap/ticdc/cdc/kv"
"github.com/pingcap/ticdc/cdc/model"
"github.com/pingcap/ticdc/pkg/config"
"github.com/pingcap/ticdc/pkg/pdtime"
"github.com/pingcap/ticdc/pkg/version"
tidbkv "github.com/pingcap/tidb/kv"
"github.com/tikv/client-go/v2/oracle"
pd "github.com/tikv/pd/client"
2 changes: 1 addition & 1 deletion pkg/context/context_test.go
Original file line number Diff line number Diff line change
@@ -136,7 +136,7 @@ func (s *contextSuite) TestThrowPanic(c *check.C) {
defer testleak.AfterTest(c)()
defer func() {
panicMsg := recover()
c.Assert(panicMsg, check.Equals, "an error has escaped, please report a bug{error 26 0 mock error}")
c.Assert(panicMsg, check.Equals, "an error has escaped, please report a bug")
}()
stdCtx := context.Background()
ctx := NewContext(stdCtx, &GlobalVars{})
2 changes: 1 addition & 1 deletion pkg/etcd/etcdkey.go
Original file line number Diff line number Diff line change
@@ -14,9 +14,9 @@
package etcd

import (
"log"
"strings"

"github.com/pingcap/log"
cerror "github.com/pingcap/ticdc/pkg/errors"
)

3 changes: 2 additions & 1 deletion pkg/orchestrator/util/key_utils.go
Original file line number Diff line number Diff line change
@@ -14,8 +14,9 @@
package util

import (
"log"
"strings"

"github.com/pingcap/log"
)

// EtcdKey represents a complete key in Etcd.