Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errors,version(ticdc): refine ErrCheckClusterVersionFromPD error #4435

Merged
merged 10 commits into from
Jan 25, 2022
Merged

errors,version(ticdc): refine ErrCheckClusterVersionFromPD error #4435

merged 10 commits into from
Jan 25, 2022

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Issue Number: close #4341

What is changed and how it works?

  • Add actual error to error message
  • Add retry hint.

Release note 

None

@overvenus overvenus added component/metrics-logging Metrics and logging component. type/enhancement The issue or PR belongs to an enhancement. area/ticdc Issues or PRs related to TiCDC. labels Jan 21, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2022 •
edited
Loading

Codecov Report

Merging #4435 (efa4d5b) into master (e469fb3) will decrease coverage by 0.4914%.
The diff coverage is 42.7777%.

Flag Coverage Δ
cdc 59.2169% <45.5882%> (-0.9705%) ⬇️
dm 52.0198% <41.0714%> (-0.0838%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4435        +/-   ##
================================================
- Coverage   55.8077%   55.3162%   -0.4915%     
================================================
  Files           495        495                
  Lines         61246      61340        +94     
================================================
- Hits          34180      33931       -249     
- Misses        23614      24007       +393     
+ Partials       3452       3402        -50

@3AceShowHand
Copy link
Contributor

/run-all-tests

overvenus
overvenus commented Jan 24, 2022
View reviewed changes
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 24, 2022
Rustin170506
Rustin170506 approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be a good to do a manual test to see exactly what the error has become now.

Change LGTM.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 24, 2022
@overvenus
address comments
048b706 
Signed-off-by: Neil Shen <[email protected]>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 24, 2022
zier-one
zier-one reviewed Jan 25, 2022
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@overvenus
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9d3bd8e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 25, 2022
@overvenus
Copy link
Member Author

/run-kafka-integration-test
/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit f51e410 into pingcap:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one zier-one left review comments

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@Rustin170506 Rustin170506 Rustin170506 approved these changes

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. component/metrics-logging Metrics and logging component. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
6 participants
@overvenus @ti-chi-bot @codecov-commenter @3AceShowHand @Rustin170506 @zier-one