-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics(dm): fix lag metrics for ddl never updated #4491
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
Co-authored-by: lance6716 <[email protected]>
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #4491 +/- ##
================================================
- Coverage 55.6402% 55.4394% -0.2008%
================================================
Files 494 498 +4
Lines 61283 61624 +341
================================================
+ Hits 34098 34164 +66
- Misses 23750 24030 +280
+ Partials 3435 3430 -5 |
could you please take another look for this pr ? thanks 🧡🧡🧡 @lichunzhu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But now when DM gets blocked will it increase lag?
this impl in #4496 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: b1d4c1f
|
/run-all-tests |
/run-verify |
What problem does this PR solve?
Issue Number: close #4471
What is changed and how it works?
if cuurrent max lag is from ddl job, reset this lag after set like skip job
Check List
Tests
Code changes
Side effects
Related changes
Release note