Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics(dm): fix lag metrics for ddl never updated #4491

Merged
merged 6 commits into from
Feb 9, 2022
Merged

metrics(dm): fix lag metrics for ddl never updated #4491

merged 6 commits into from
Feb 9, 2022

Conversation

Ehco1996
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #4471

What is changed and how it works?

if cuurrent max lag is from ddl job, reset this lag after set like skip job

Check List

Tests

  • Integration test

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

Release note

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 27, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lance6716
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 27, 2022
@lance6716 lance6716 added the area/dm Issues or PRs related to DM. label Jan 27, 2022
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2022

Codecov Report

Merging #4491 (b1d4c1f) into master (9607554) will decrease coverage by 0.2007%.
The diff coverage is 47.6190%.

Flag Coverage Δ
cdc 60.0992% <70.5882%> (+0.1770%) ⬆️
dm 51.5585% <34.2465%> (-0.4704%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4491        +/-   ##
================================================
- Coverage   55.6402%   55.4394%   -0.2008%     
================================================
  Files           494        498         +4     
  Lines         61283      61624       +341     
================================================
+ Hits          34098      34164        +66     
- Misses        23750      24030       +280     
+ Partials       3435       3430         -5     

@Ehco1996
Copy link
Contributor Author

Ehco1996 commented Feb 8, 2022

could you please take another look for this pr ? thanks 🧡🧡🧡 @lichunzhu

Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
But now when DM gets blocked will it increase lag?

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 8, 2022
@Ehco1996
Copy link
Contributor Author

Ehco1996 commented Feb 8, 2022

LGTM But now when DM gets blocked will it increase lag?

this impl in #4496

@Ehco1996
Copy link
Contributor Author

Ehco1996 commented Feb 8, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b1d4c1f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2022
@Ehco1996
Copy link
Contributor Author

Ehco1996 commented Feb 8, 2022

/run-all-tests

@Ehco1996
Copy link
Contributor Author

Ehco1996 commented Feb 8, 2022

/run-verify

@ti-chi-bot ti-chi-bot merged commit be7b742 into pingcap:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DM secondsBehindMaster of query-status not accurate
5 participants