Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd (ticdc): fix a data race in unit test #4551

Merged
merged 9 commits into from
Feb 13, 2022

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Feb 10, 2022

What problem does this PR solve?

Issue Number: close #4549

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • None

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 10, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ben1009

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 10, 2022
@asddongmen asddongmen added area/ticdc Issues or PRs related to TiCDC. component/test Unit tests and integration tests component. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Feb 10, 2022
@ti-chi-bot
Copy link
Member

@CharlesCheung96: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

Codecov Report

Merging #4551 (f7085d9) into master (9607554) will decrease coverage by 0.0064%.
The diff coverage is 59.5223%.

Flag Coverage Δ
cdc 60.3340% <64.6700%> (+0.4118%) ⬆️
dm 51.6355% <51.6975%> (-0.3934%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4551        +/-   ##
================================================
- Coverage   55.6402%   55.6337%   -0.0065%     
================================================
  Files           494        503         +9     
  Lines         61283      62516      +1233     
================================================
+ Hits          34098      34780       +682     
- Misses        23750      24274       +524     
- Partials       3435       3462        +27     

Co-authored-by: zhaoxinyu <[email protected]>
@ti-chi-bot
Copy link
Member

@zhaoxinyu: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 11, 2022
@asddongmen asddongmen added needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. labels Feb 11, 2022
@asddongmen asddongmen added the require-LGT1 Indicates that the PR requires an LGTM. label Feb 11, 2022
@asddongmen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f7085d9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 11, 2022
@ti-chi-bot ti-chi-bot merged commit fc3b5ad into pingcap:master Feb 13, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 13, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4576.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4577.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 13, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 13, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4578.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Feb 13, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4579.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4580.

zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Feb 16, 2022
asddongmen added a commit to ti-chi-bot/tiflow that referenced this pull request Feb 18, 2022
asddongmen added a commit to ti-chi-bot/tiflow that referenced this pull request Feb 18, 2022
@asddongmen asddongmen deleted the fix_data_race_in_ut branch June 15, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. component/test Unit tests and integration tests component. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: data race found in TestRevisionNotFallBack
6 participants