Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(dm): fix unsteable test TestRedirectRequestToLeader #4556

Merged
merged 10 commits into from
Feb 14, 2022
Merged

test(dm): fix unsteable test TestRedirectRequestToLeader #4556

merged 10 commits into from
Feb 14, 2022

Conversation

Ehco1996
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #4554

What is changed and how it works?

send reuest after master ready

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 10, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2022
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also fix that when test failed cancel is not called so it will enter deadlock

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

Codecov Report

Merging #4556 (0f49d3e) into master (9607554) will decrease coverage by 0.1184%.
The diff coverage is 59.5223%.

Flag Coverage Δ
cdc 60.2192% <64.6700%> (+0.2969%) ⬆️
dm 51.5260% <51.6975%> (-0.5029%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4556        +/-   ##
================================================
- Coverage   55.6402%   55.5217%   -0.1185%     
================================================
  Files           494        503         +9     
  Lines         61283      62516      +1233     
================================================
+ Hits          34098      34710       +612     
- Misses        23750      24331       +581     
- Partials       3435       3475        +40     

@Ehco1996 Ehco1996 added the status/ptal Could you please take a look? label Feb 11, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 11, 2022
@Ehco1996
Copy link
Contributor Author

could you please take another look for this pr ? thanks 🧡🧡🧡

@lance6716

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2022
@D3Hunter
Copy link
Contributor

/run-all-tests

@Ehco1996
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6273293

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2022
@ti-chi-bot
Copy link
Member

@Ehco1996: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit e230160 into pingcap:master Feb 14, 2022
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Feb 16, 2022
@lance6716 lance6716 added needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Feb 22, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4649.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4650.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DM TestRedirectRequestToLeader
5 participants