-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(ticdc): fix canal_json_basic charset issue #4558
tests(ticdc): fix canal_json_basic charset issue #4558
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
/run-kafka-integration-test |
/check-issue-triage-complete |
/run-kafka-integration-test |
/run-kafka-integration-test |
/run-kafka-integration-test |
1 similar comment
/run-kafka-integration-test |
/run-all-tests |
Is this a bug of |
I think this is a bug in tidb, because the sql is executed in tidb. |
Do we have a linked issue in TiDB |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 52aa725
|
@hi-rustin: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-verify |
What problem does this PR solve?
Issue Number: ref #4555
What is changed and how it works?
sync diff will concat_ws all fields when calculating checksum. This causes some string conversions. Then an error occurs during the conversion.
This value is not a valid utf8 value.

So I modified it for now. The exact reason why it worked before the default charset change is still under investigation.
Check List
Tests
Code changes
None
Side effects
None
Related changes
None
Release note