ticdc(mounter): remove unnecessary delete event decode logic #4602
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/needs-triage-completed
release-note-none
|
/run-all-tests |
|
/run-integration-test |
|
@tangenta: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-kafka-integration-test |
|
LGTM |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 16c85a8
|
ti-chi-bot
added
the
status/can-merge
|
/run-integration-test |
|
/run-kafka-integration-test |
3 similar comments
|
/run-kafka-integration-test |
|
/run-kafka-integration-test |
|
/run-kafka-integration-test |
|
@hi-rustin: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-kafka-integration-test |
What problem does this PR solve?
Issue Number: close #4582
What is changed and how it works?
The original part of the logic was to find the handle column of the delete event when pkishandle. But now the TiCDC puller node pulls the old value by default, so we don't need to do this anymore.
Check List
Tests
Code changes
None
Side effects
None
Related changes
None
Release note