Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capture(ticdc): fix the problem that openapi is blocked when pd is abnormal (#4788) #5112

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4788

What problem does this PR solve?

Issue Number: close #4778

What is changed and how it works?

  1. Avoid holding a mutex lock in a blocking operation.
  2. Add timeout control for EtcdClient get and put operations to prevent possible goroutine leak in openapi.
    rZvF5Nx4BM
  3. Remove redundant retry operations in (*openApi).forwardToOwner

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

`Fix a bug that openapi may be stuck when pd is abnormal`

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 2, 2022
@ti-chi-bot ti-chi-bot added component/api HTTP API. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Apr 2, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 22, 2022
@CharlesCheung96
Copy link
Contributor

Batch cherry-pick through #4533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/api HTTP API. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants