Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(engine): fix start etcd test failure because of duplicated free port #5516

Merged
merged 3 commits into from
May 23, 2022
Merged

test(engine): fix start etcd test failure because of duplicated free port #5516

merged 3 commits into from
May 23, 2022

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented May 23, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5515

What is changed and how it works?

Network raw listen on :0 could get a duplicated free port, just retry several times to get a different port.

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • liuzix
  • maxshuang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels May 23, 2022
@amyangfei amyangfei added component/test Unit tests and integration tests component. area/engine Issues or PRs related to Dataflow Engine. labels May 23, 2022
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 23, 2022
@amyangfei
Copy link
Contributor Author

/check-issue-triage-complete

@amyangfei amyangfei added the status/ptal Could you please take a look? label May 23, 2022
@amyangfei
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 23, 2022
@amyangfei amyangfei requested a review from maxshuang May 23, 2022 04:04
maxshuang
maxshuang reviewed May 23, 2022
View reviewed changes
engine/servermaster/etcd_test.go
@@ -53,7 +53,11 @@ func TestStartEtcdTimeout(t *testing.T) {
cfgCluster.Name = name1
cfgCluster.DataDir = dir
peer1 := allocTempURL(t)
peer2 := allocTempURL(t)
peer2 := peer1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the main reason we get this error is peer1 is not used when allocate peer2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need change the pr discription before merge this pr.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 23, 2022
@amyangfei amyangfei changed the title test(engine): fix etcd wrong error message when allocating same ports test(engine): fix start etcd test failure because of duplicated free port May 23, 2022
@amyangfei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8525191

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 23, 2022
@amyangfei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@amyangfei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 69c7ae2 into pingcap:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxshuang maxshuang maxshuang approved these changes

@liuzix liuzix liuzix approved these changes

Assignees
No one assigned
Labels
area/engine Issues or PRs related to Dataflow Engine. component/test Unit tests and integration tests component. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unstable unit test TestStartEtcdTimeout in dataflow engine
4 participants
@amyangfei @ti-chi-bot @maxshuang @liuzix