Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: log some critical information to stdout but not log file #597

Merged
merged 2 commits into from
May 27, 2020

Conversation

zier-one
Copy link
Contributor

@zier-one zier-one commented May 26, 2020

What problem does this PR solve?

fix #542 (8) #343

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Release note

@zier-one zier-one requested a review from overvenus May 26, 2020 06:46
@zier-one zier-one added the status/ptal Could you please take a look? label May 27, 2020
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one added LGT1 and removed status/ptal Could you please take a look? labels May 27, 2020
@zier-one
Copy link
Contributor Author

/run-integration-tests

1 similar comment
@zier-one
Copy link
Contributor Author

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #597 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #597   +/-   ##
===========================================
  Coverage   33.8583%   33.8583%           
===========================================
  Files            73         73           
  Lines          7555       7555           
===========================================
  Hits           2558       2558           
  Misses         4818       4818           
  Partials        179        179           

@zier-one zier-one merged commit cced25f into pingcap:master May 27, 2020
@zier-one zier-one deleted the reduce_log branch June 8, 2020 03:31
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve usability in cdc client
3 participants