owner: ignore the invalid admin jobs #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zier-one
commented
May 27, 2020
added 2 commits
May 27, 2020 13:43
overvenus
reviewed
Jun 1, 2020
| @@ -143,6 +145,9 @@ func newQueryChangefeedCommand() *cobra.Command { | |||
| taskStatus = append(taskStatus, captureTaskStatus{CaptureID: captureID, TaskStatus: status}) | |||
| } | |||
| meta := &cfMeta{Info: info, Status: status, Count: count, TaskStatus: taskStatus} | |||
| if info == nil { | |||
| log.Warn("this changefeed has been deleted, the residual meta data will be completely deleted within 24 hours.") | |||
There was a problem hiding this comment.
How do we test it if it is get deleted after 24 hours?
There was a problem hiding this comment.
i will add a unit test for it
overvenus
reviewed
Jun 2, 2020
zier-one
commented
Jun 2, 2020
zier-one
commented
Jun 2, 2020
|
/run-integration-tests |
overvenus
approved these changes
Jun 2, 2020
|
/run-integration-tests |
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
================================================
+ Coverage 33.3333% 33.4335% +0.1002%
================================================
Files 74 74
Lines 7626 7651 +25
================================================
+ Hits 2542 2558 +16
- Misses 4902 4905 +3
- Partials 182 188 +6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #541 #542.(3)
ignore and warn the invalid admin jobs.
if users remove the changefeed, the owner will delete the changefeed info immediately and set 24h TTL to the changefeed status.
the CDC CLI will report a warning to tall users the changefeed has been deleted.
What is changed and how it works?
Check List
Tests
Release note