Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make sure the pd is started #618

Merged
merged 2 commits into from
Jun 8, 2020
Merged

Conversation

zier-one
Copy link
Contributor

@zier-one zier-one commented Jun 5, 2020

What problem does this PR solve?

make sure the pd is started

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Release note

@zier-one
Copy link
Contributor Author

zier-one commented Jun 5, 2020

/run-integration-tests

1 similar comment
@zier-one
Copy link
Contributor Author

zier-one commented Jun 5, 2020

/run-integration-tests

@zier-one
Copy link
Contributor Author

zier-one commented Jun 5, 2020

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #618 into master will decrease coverage by 0.0129%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master       #618        +/-   ##
================================================
- Coverage   33.2427%   33.2298%   -0.0130%     
================================================
  Files            74         74                
  Lines          7728       7728                
================================================
- Hits           2569       2568         -1     
- Misses         4970       4971         +1     
  Partials        189        189                

Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one merged commit cbf9485 into pingcap:master Jun 8, 2020
@amyangfei amyangfei added the LGT1 label Jun 8, 2020
@zier-one zier-one deleted the fix_tidb branch June 8, 2020 03:30
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants