Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changefeed summary in list command, add some shortcut #721

Merged
merged 2 commits into from
Jul 8, 2020

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented Jul 6, 2020

What problem does this PR solve?

Fix item-12 in pingcap/ticdc#542

What is changed and how it works?

  • Add a summary filed in changefeed list
  • Accepts a shorthand letter for some variable name, including c is short for changefeed-id, p is short for `capture-id

Sample output

➜  ./cdc cli changefeed list
[
  {
    "id": "4e24dde6-53c1-40b6-badf-63620e4940dc",
    "summary": {
      "state": "normal",
      "tso": 417886179132964865,
      "checkpoint": "2020-07-07 16:07:44.881",
      "error": null
    }
  },
  {
    "id": "8f0bd661-e3ab-4e25-a8eb-d835c0348a58",
    "summary": {
      "state": "stopped",
      "tso": 417885338318929921,
      "checkpoint": "2020-07-07 15:14:17.430",
      "error": null
    }
  }
]

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to update the documentation

Release note

  • No release note

@amyangfei amyangfei added the subject/usability Denotes an issue or pull request is related to usability. label Jul 6, 2020
@amyangfei
Copy link
Contributor Author

/run-integration-tests

@amyangfei amyangfei added the status/ptal Could you please take a look? label Jul 6, 2020
@amyangfei amyangfei mentioned this pull request Jul 7, 2020
5 tasks
Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added LGT1 and removed status/ptal Could you please take a look? labels Jul 8, 2020
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one added LGT2 and removed LGT1 labels Jul 8, 2020
@amyangfei
Copy link
Contributor Author

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #721 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #721   +/-   ##
===========================================
  Coverage   34.3884%   34.3884%           
===========================================
  Files            91         91           
  Lines          9762       9762           
===========================================
  Hits           3357       3357           
  Misses         6103       6103           
  Partials        302        302           

@amyangfei amyangfei merged commit ceb3287 into pingcap:master Jul 8, 2020
@amyangfei amyangfei deleted the refine-some-cli-output branch July 8, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subject/usability Denotes an issue or pull request is related to usability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants