Kafka Connect Avro Support Part 2: AvroEventBatchEncoder #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuzix
changed the title
overvenus
reviewed
Jul 9, 2020
cdc/puller/mock_puller.go
Outdated
| pm: m, | ||
| startTs: startTs, | ||
| } | ||
| //return nil |
|
|
||
| package codec | ||
|
|
||
| import ( |
There was a problem hiding this comment.
import order should be
std libs
<new line>
third-party libs
cdc/sink/codec/avro_test.go
Outdated
| "time" | ||
| ) | ||
|
|
||
| type AvroBatchEncoderSuite struct { |
There was a problem hiding this comment.
Suggested change
| type AvroBatchEncoderSuite struct { | |
| type avroBatchEncoderSuite struct { |
Please avoid unnecessary exports.
| @@ -44,7 +44,7 @@ type mockRegistrySchema struct { | |||
| ID int | |||
| } | |||
|
|
|||
| func (s *AvroSchemaRegistrySuite) SetUpSuite(c *check.C) { | |||
| func StartHTTPInterceptForTestingRegistry(c *check.C) { | |||
There was a problem hiding this comment.
Suggested change
| func StartHTTPInterceptForTestingRegistry(c *check.C) { | |
| func startHTTPInterceptForTestingRegistry(c *check.C) { |
| @@ -140,10 +140,18 @@ func (s *AvroSchemaRegistrySuite) SetUpSuite(c *check.C) { | |||
|
|
|||
| } | |||
|
|
|||
| func (s *AvroSchemaRegistrySuite) TearDownSuite(c *check.C) { | |||
| func StopHTTPInterceptForTestingRegistry() { | |||
There was a problem hiding this comment.
Suggested change
| func StopHTTPInterceptForTestingRegistry() { | |
| func stopHTTPInterceptForTestingRegistry() { |
cdc/sink/codec/avro.go
Outdated
| return "long.timestamp-millis" | ||
| default: | ||
| log.Warn("getAvroDataTypeName: unknown type") | ||
| return "errorType" |
amyangfei
reviewed
Jul 9, 2020
amyangfei
added
component/sink
|
/lgtm |
|
@amyangfei,Thanks for your review. |
zier-one
reviewed
Jul 13, 2020
| Schema string | ||
| SchemaID int64 | ||
| Table string | ||
| ColumnInfo []*ColumnInfo |
There was a problem hiding this comment.
I think we could use a TableInfo with a table name, schema name, column info, etc.
zier-one
suggested changes
Jul 14, 2020
|
/lgtm |
ti-srebot
approved these changes
Jul 14, 2020
zier-one
approved these changes
Jul 14, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@liuzix merge failed. |
|
Please fix the build error @liuzix |
|
/merge |
|
/run-all-tests |
|
/merge |
1 similar comment
|
/merge |
|
@liuzix merge failed. |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#660
What is changed and how it works?
Add AvroEventBatchEncoder which handles RowChangedEvent and DDLEvent.
Check List
Tests
Code changes
TODO:
Release note