Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka Connect Avro Support Part 3: Basic Avro support #753

Merged
merged 13 commits into from
Jul 15, 2020
Merged

Kafka Connect Avro Support Part 3: Basic Avro support #753

merged 13 commits into from
Jul 15, 2020

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Jul 15, 2020 •
edited
Loading

What problem does this PR solve?

#660

What is changed and how it works?

MqSink now supports protocol "avro".

Check List

Tests

  • Unit test
  • Manual test: Syncing through Kafka JDBC sink connector tested.

Code changes

  • Has interface methods change

Related changes

- Need to update the documentation
- Replicating date or timestamp data may not work for now.
- Enable it by adding "protocol=avro" to sink-uri and "-opts registry=http://..." when creating change feed.

Release note

  • Add Avro support in mq sink, which enables Kafka sink connector to work together with TiCDC.

@liuzix liuzix added the component/sink Sink component. label Jul 15, 2020
@sre-bot
Copy link

sre-bot commented Jul 15, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@zier-one zier-one added this to the v4.0.3 milestone Jul 15, 2020
@zier-one zier-one added the release-blocker This issue blocks a release. Please solve it ASAP. label Jul 15, 2020
amyangfei
amyangfei reviewed Jul 15, 2020
View reviewed changes
cdc/sink/mq.go Outdated Show resolved Hide resolved
cdc/sink/mq.go Outdated Show resolved Hide resolved
cdc/sink/mq.go Outdated Show resolved Hide resolved
@amyangfei
Copy link
Contributor

Please merge master and resolve conflict

@sre-bot
Copy link

sre-bot commented Jul 15, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@liuzix liuzix force-pushed the zixiong-avro-sink branch from acfeceb to 941fad7 Compare July 15, 2020 09:58
@sre-bot
Copy link

sre-bot commented Jul 15, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@sre-bot
Copy link

sre-bot commented Jul 15, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@zier-one
Copy link
Contributor

please fix build

@sre-bot
Copy link

sre-bot commented Jul 15, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@amyangfei
Copy link
Contributor

/rebuild

@sre-bot
Copy link

sre-bot commented Jul 15, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@amyangfei
Copy link
Contributor

/rebuild

@amyangfei
Copy link
Contributor

/run-integration-tests

@zier-one
Copy link
Contributor

/run-integration-tests

@zier-one
Copy link
Contributor

/run-integration-tests

zier-one
zier-one reviewed Jul 15, 2020
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

cdc/model/sink.go Outdated Show resolved Hide resolved
@zier-one
Copy link
Contributor

/run-integration-tests

@zier-one
Copy link
Contributor

/lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2020
@amyangfei
Copy link
Contributor

/lgtm

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 15, 2020
@amyangfei
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 15, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 755

@overvenus
Copy link
Member

/run-all-tests

1 similar comment
@ti-srebot
Copy link
Contributor

/run-all-tests

@codecov-commenter
Copy link

Codecov Report

Merging #753 into master will decrease coverage by 0.2011%.
The diff coverage is 12.3893%.

@@               Coverage Diff                @@
##             master       #753        +/-   ##
================================================
- Coverage   33.8838%   33.6826%   -0.2012%     
================================================
  Files            92         92                
  Lines         10052      10115        +63     
================================================
+ Hits           3406       3407         +1     
- Misses         6314       6378        +64     
+ Partials        332        330         -2

@ti-srebot ti-srebot merged commit 583ced8 into pingcap:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one zier-one left review comments

@amyangfei amyangfei amyangfei left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
component/sink Sink component. release-blocker This issue blocks a release. Please solve it ASAP. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
v4.0.3
Development

Successfully merging this pull request may close these issues.
7 participants
@liuzix @sre-bot @amyangfei @zier-one @ti-srebot @overvenus @codecov-commenter