Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc/sink: support Kafka SSL connection #764

Merged
merged 11 commits into from
Jul 21, 2020
Merged

cdc/sink: support Kafka SSL connection #764

merged 11 commits into from
Jul 21, 2020

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Support Kafka SSL connection.

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

  • Support Kafka SSL connection.

@overvenus overvenus added the component/sink Sink component. label Jul 17, 2020
@overvenus overvenus added this to the v4.0.4 milestone Jul 17, 2020
@overvenus
Copy link
Member Author

/run-all-tests

@overvenus
update label
1d0b9c0 
Signed-off-by: Neil Shen <[email protected]>
@overvenus
Copy link
Member Author

/run-all-tests

@DanielZhangQD DanielZhangQD mentioned this pull request Jul 17, 2020
Closed
6 tasks
overvenus added 2 commits July 17, 2020 20:59
@overvenus
use http if necessary
6270375 
Signed-off-by: Neil Shen <[email protected]>
@overvenus
fix build
cac7256 
Signed-off-by: Neil Shen <[email protected]>
@overvenus
Copy link
Member Author

/run-kafka-tests

@overvenus
i=0
6e62afc 
Signed-off-by: Neil Shen <[email protected]>
@overvenus
Copy link
Member Author

/run-kafka-tests

@overvenus
Copy link
Member Author

/run-kafka-tests

@overvenus
Copy link
Member Author

/run-kafka-tests

@overvenus overvenus added the status/ptal Could you please take a look? label Jul 17, 2020
@overvenus overvenus marked this pull request as ready for review July 17, 2020 16:15
amyangfei
amyangfei reviewed Jul 21, 2020
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 21, 2020
@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 21, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 21, 2020
@zier-one
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 21, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 752
  • 760

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@overvenus merge failed.

@amyangfei
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@overvenus merge failed.

@amyangfei
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 6a62c20 into pingcap:master Jul 21, 2020
@amyangfei amyangfei mentioned this pull request Jul 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei left review comments

@zier-one zier-one zier-one approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@liuzix liuzix Awaiting requested review from liuzix

Assignees
No one assigned
Labels
component/sink Sink component. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
v4.0.5
Development

Successfully merging this pull request may close these issues.
4 participants
@overvenus @zier-one @ti-srebot @amyangfei