Fix mysql sink may be blocked by network io wait #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #825 +/- ##
================================================
- Coverage 32.4760% 32.4663% -0.0098%
================================================
Files 97 97
Lines 10848 10765 -83
================================================
- Hits 3523 3495 -28
+ Misses 6991 6934 -57
- Partials 334 336 +2 |
|
/run-integration-tests |
zier-one
reviewed
Aug 6, 2020
cdc/sink/mysql.go
Outdated
| for _, w := range s.workers { | ||
| w.waitAllTxnsExecuted() | ||
| } | ||
| done <- struct{}{} |
There was a problem hiding this comment.
Suggested change
| done <- struct{}{} | |
| close(done) |
zier-one
reviewed
Aug 6, 2020
cdc/sink/mysql.go
Outdated
| s.notifier.Notify() | ||
| for _, w := range s.workers { | ||
| w.waitAllTxnsExecuted() | ||
| done := make(chan struct{}, 1) |
There was a problem hiding this comment.
Suggested change
| done := make(chan struct{}, 1) | |
| done := make(chan struct{}) |
zier-one
approved these changes
Aug 6, 2020
|
/merge |
|
@leoppro Oops! This PR requires at least 2 LGTMs to merge. The current number of |
|
/run-integration-tests |
|
/lgtm |
ti-srebot
approved these changes
Aug 6, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/merge |
|
/run-all-tests |
|
/merge |
1 similar comment
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In a test when TiDB cluster is abnormal, ticdc executes DMLs with some errors, but one of goroutine is hang up and blocks the whole sink
What is changed and how it works?
Use a hack code to avoid io wait in some routine blocks others to exit.
As the network io wait is blocked in kernel code, the goroutine is in a
D-state that we could not even stop it by canceling the context. So if this
scenario happens, the blocked goroutine will be leak.
Check List
Tests
Release note