Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more expression for VectorFloat32 type #322

Merged

Conversation

Mini256
Copy link
Member

@Mini256 Mini256 commented Jan 17, 2024

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

@CLAassistant
Copy link

CLAassistant commented Jan 17, 2024

CLA assistant check
All committers have signed the CLA.

@Mini256 Mini256 requested a review from breezewish January 17, 2024 02:34
@Mini256 Mini256 changed the title Add compare expression for VectorFloat32 type Add more expression for VectorFloat32 type Jan 21, 2024
@breezewish
Copy link
Member

Thanks! Please only include expression.go/proto. Other changes will cause unit test to fail.

@Mini256
Copy link
Member Author

Mini256 commented Jan 22, 2024

Please only include expression.go/proto. Other changes will cause unit test to fail.

It seems that there are some differences between Protoc 3.5.1 and 3.20.3 (the version I am currently using on local).

The CI encountered a rate limit error, and I will trigger the test again later.

@breezewish
Copy link
Member

I will fix it in my PR.

@breezewish breezewish merged commit b1e29ed into pingcap:wenxuan/vector Jan 22, 2024
2 of 4 checks passed
breezewish added a commit that referenced this pull request Jan 22, 2024
with #322

Signed-off-by: Wish <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants