-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more expression for VectorFloat32 type #322
Merged
breezewish
merged 9 commits into
pingcap:wenxuan/vector
from
Mini256:add-compare-expr-for-vector-type
Jan 22, 2024
Merged
Add more expression for VectorFloat32 type #322
breezewish
merged 9 commits into
pingcap:wenxuan/vector
from
Mini256:add-compare-expr-for-vector-type
Jan 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mini256
changed the title
Add compare expression for VectorFloat32 type
Add more expression for VectorFloat32 type
Jan 21, 2024
Thanks! Please only include expression.go/proto. Other changes will cause unit test to fail. |
It seems that there are some differences between Protoc 3.5.1 and 3.20.3 (the version I am currently using on local). The CI encountered a rate limit error, and I will trigger the test again later. |
I will fix it in my PR. |
breezewish
added a commit
that referenced
this pull request
Jan 22, 2024
with #322 Signed-off-by: Wish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Related changes
pingcap/docs
/pingcap/docs-cn
: