Support fallback when resolveLockAsync #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
shiyuhang0
force-pushed
the
resolve_lock_fallback
branch
from
9ff50fe to
d305f98
Compare
shiyuhang0
changed the title
|
/run-all-tests |
shiyuhang0
force-pushed
the
resolve_lock_fallback
branch
from
bfd4fbd to
54e83fa
Compare
|
/run-all-tests |
|
/run-all-tests |
xuanyu66
approved these changes
Mar 17, 2023
Daemonxiao
approved these changes
Mar 20, 2023
|
/run-all-tests |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: e708b66
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
If we does not fallback in the resolveLockAsync. TiSpark may commit the txn which should be rollback.
What is changed and how it works?
refer to client-go https://github.com/tikv/client-go/blob/daddf73a0706d78c9e980c91c97cc9ed100f1919/txnkv/txnlock/lock_resolver.go#L341
When we checkSecondaries and find the lock did not use AsyncCommit. Just throw an exception. resolveLockAsync will fallback when it catches the exception